Bug 103554

Summary: IndexedDB: Remove duplicate toWireString() and createFromWire() methods in JSC SerializedScriptValue
Product: WebKit Reporter: Michael Pruett <michael>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, haraken, jsbell, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103484    
Attachments:
Description Flags
Patch
haraken: review+, buildbot: commit-queue-
Patch
webkit.review.bot: commit-queue-
Patch none

Michael Pruett
Reported 2012-11-28 13:03:23 PST
In r135022, duplicate createFromWire() and toWireString() methods were added to the JSC version of SerializedScriptValue. This class already has methods of those same names with quite different implementations guarded by ENABLED(INDEXED_DATABASE). In order to allow the JSC SerializedScriptValue to compile when ENABLE(INDEXED_DATABASE) is turned on, these competing definitions should be resolved.
Attachments
Patch (7.18 KB, patch)
2012-11-28 15:14 PST, Michael Pruett 		haraken: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch (13.17 KB, patch)
2012-11-28 17:37 PST, Michael Pruett 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (13.05 KB, patch)
2012-11-28 21:57 PST, Michael Pruett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michael Pruett
Comment 1 2012-11-28 15:14:32 PST
Created attachment 176587 [details] Patch This patch fixes compilation of the JSC version of SerializedScriptValue.cpp when ENABLE(INDEXED_DATABASE) is turned on.
Build Bot
Comment 2 2012-11-28 15:48:30 PST
Comment on attachment 176587 [details] Patch Attachment 176587 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15027587
Kentaro Hara
Comment 3 2012-11-28 15:59:02 PST
Looks good to me, though you need to expose symbols to other files to fix the build problems (see http://trac.webkit.org/wiki/ExportingSymbols). jsbell, alecflett: would you take a look?
Build Bot
Comment 4 2012-11-28 16:00:48 PST
Comment on attachment 176587 [details] Patch Attachment 176587 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15028593
Joshua Bell
Comment 5 2012-11-28 16:08:09 PST
(In reply to comment #3) > jsbell, alecflett: would you take a look? LGTM.
Kentaro Hara
Comment 6 2012-11-28 16:10:32 PST
Comment on attachment 176587 [details] Patch Please fix symbol export issues before landing.
Michael Pruett
Comment 7 2012-11-28 17:37:58 PST
Created attachment 176612 [details] Patch I've added SerializedScriptValue's toWireString() and createFromWire() to the Windows and Mac symbol export files.
Kentaro Hara
Comment 8 2012-11-28 21:42:07 PST
Comment on attachment 176612 [details] Patch ok, now bots look happy.
WebKit Review Bot
Comment 9 2012-11-28 21:46:24 PST
Comment on attachment 176612 [details] Patch Rejecting attachment 176612 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15013741
Kentaro Hara
Comment 10 2012-11-28 21:47:32 PST
Comment on attachment 176612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176612&action=review > ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Please manually add my name here. > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). and here.
Michael Pruett
Comment 11 2012-11-28 21:57:48 PST
Created attachment 176647 [details] Patch I have added Kentaro Hara as the reviewer for this patch in the ChangeLog messages.
WebKit Review Bot
Comment 12 2012-11-28 22:22:09 PST
Comment on attachment 176647 [details] Patch Clearing flags on attachment: 176647 Committed r136097: <http://trac.webkit.org/changeset/136097>
WebKit Review Bot
Comment 13 2012-11-28 22:22:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.