Bug 103481

Summary: [Shadow] Move Distribution requirements from ShadowRoot
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: gtk-ews, ojan, webcomponents-bugzilla, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97279    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Shinya Kawanaka
Reported 2012-11-27 22:21:00 PST
We would like to make ShadowRoot as small as possible. Currently ShadowRoot has several ContentDistribution stuffs which are used only for ShadowRoot having <content>, <shadow> or nested ShadowRoot. We woud like to move them somewhere.
Attachments
Patch (9.19 KB, patch)
2012-11-28 00:33 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (13.42 KB, patch)
2012-11-28 02:48 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (18.01 KB, patch)
2012-11-28 03:57 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.01 KB, patch)
2012-11-28 17:58 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-28 00:32:36 PST
Apple folks seem to reduce memory footprint aggressively now.
Shinya Kawanaka
Comment 2 2012-11-28 00:33:31 PST
Created attachment 176417 [details] Patch
Shinya Kawanaka
Comment 3 2012-11-28 01:49:09 PST
Let's move DistributionData into ContentDistribution.h
Shinya Kawanaka
Comment 4 2012-11-28 02:48:10 PST
Created attachment 176436 [details] Patch
Build Bot
Comment 5 2012-11-28 03:03:45 PST
Comment on attachment 176436 [details] Patch Attachment 176436 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15016356
kov's GTK+ EWS bot
Comment 6 2012-11-28 03:16:32 PST
Comment on attachment 176436 [details] Patch Attachment 176436 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15027358
Build Bot
Comment 7 2012-11-28 03:23:37 PST
Comment on attachment 176436 [details] Patch Attachment 176436 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15031177
Shinya Kawanaka
Comment 8 2012-11-28 03:57:32 PST
Created attachment 176450 [details] Patch
Hajime Morrita
Comment 9 2012-11-28 06:09:02 PST
Comment on attachment 176450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176450&action=review > Source/WebCore/ChangeLog:10 > + Since <input> or <textarea> do not have such stuffs, the members consume a few amount of memory. s/stuffs/stuff/ > Source/WebCore/dom/ShadowRoot.cpp:352 > + return distributionData()->numberOfShadowElementChildren() > 0; hasXXX could be a method on ShadowRootContentDistributionData > Source/WebCore/dom/ShadowRoot.cpp:370 > + return distributionData()->numberOfContentElementChildren() > 0; Ditto. > Source/WebCore/dom/ShadowRoot.cpp:389 > + return distributionData()->numberOfElementShadowChildren() > 0; Ditto.
Dimitri Glazkov (Google)
Comment 10 2012-11-28 08:41:33 PST
Comment on attachment 176450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176450&action=review >> Source/WebCore/ChangeLog:10 >> + Since <input> or <textarea> do not have such stuffs, the members consume a few amount of memory. > > s/stuffs/stuff/ s/stuffs/requirements/ </bikeshed>
Shinya Kawanaka
Comment 11 2012-11-28 17:58:13 PST
Created attachment 176617 [details] Patch for landing
WebKit Review Bot
Comment 12 2012-11-28 18:19:10 PST
Comment on attachment 176617 [details] Patch for landing Clearing flags on attachment: 176617 Committed r136081: <http://trac.webkit.org/changeset/136081>
WebKit Review Bot
Comment 13 2012-11-28 18:19:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.