Bug 103075

Summary: RenderBox::computePercentageLogicalHeight should use containingBlockLogicalWidthForContent
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, donggwan.kim, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 102968    
Attachments:
Description Flags
Proposed change.
none
Updated patch: As we may use one of our ancestor's containing block, we need to call the function on it.
none
Rebaselined change for the EWS. none

Julien Chaffraix
Reported 2012-11-22 08:57:22 PST
Currently the code is the following: if (isHorizontalWritingMode() != cb->isHorizontalWritingMode()) availableHeight = cb->contentLogicalWidth(); (http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBox.cpp#L2209) This is right for most renderers but there are some special cases: * captions need to match the table's logical width, not the table's content logical width. * multi-column renderers need to constrain the logical width to match the column size. Those 2 cases are broken in ToT when we have orthogonal writing modes.
Attachments
Proposed change. (7.18 KB, patch)
2012-11-22 09:21 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Updated patch: As we may use one of our ancestor's containing block, we need to call the function on it. (8.04 KB, patch)
2012-11-23 10:03 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Rebaselined change for the EWS. (7.94 KB, patch)
2012-11-23 10:49 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-11-22 09:21:17 PST
Created attachment 175686 [details] Proposed change.
Build Bot
Comment 2 2012-11-22 12:12:39 PST
Comment on attachment 175686 [details] Proposed change. Attachment 175686 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14937466 New failing tests: fast/table/height-percent-test-vertical.html
Ojan Vafai
Comment 3 2012-11-22 12:36:37 PST
(In reply to comment #2) > New failing tests: > fast/table/height-percent-test-vertical.html Looks likely this is a real failure.
WebKit Review Bot
Comment 4 2012-11-22 23:21:47 PST
Comment on attachment 175686 [details] Proposed change. Attachment 175686 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14967609 New failing tests: fast/table/height-percent-test-vertical.html inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Julien Chaffraix
Comment 5 2012-11-23 10:03:21 PST
Created attachment 175825 [details] Updated patch: As we may use one of our ancestor's containing block, we need to call the function on it.
Julien Chaffraix
Comment 6 2012-11-23 10:49:39 PST
Created attachment 175827 [details] Rebaselined change for the EWS.
WebKit Review Bot
Comment 7 2012-11-26 11:08:07 PST
Comment on attachment 175827 [details] Rebaselined change for the EWS. Clearing flags on attachment: 175827 Committed r135741: <http://trac.webkit.org/changeset/135741>
WebKit Review Bot
Comment 8 2012-11-26 11:08:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.