Bug 102911

Summary: [Shadow DOM] Implement Element::createShadowRoot()
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, ericbidelman, haraken, ojan, ossy, philn, webcomponents-bugzilla, webkit.review.bot, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103026    
Bug Blocks: 63606, 102913    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Attachments
Patch (5.38 KB, patch)
2012-11-21 17:23 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.22 KB, patch)
2012-11-22 00:37 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.29 KB, patch)
2012-11-25 17:47 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-11-21 17:23:55 PST
Created attachment 175553 [details] Patch
Kentaro Hara
Comment 2 2012-11-21 17:27:12 PST
Comment on attachment 175553 [details] Patch Looks OK
WebKit Review Bot
Comment 3 2012-11-21 19:15:56 PST
Comment on attachment 175553 [details] Patch Clearing flags on attachment: 175553 Committed r135464: <http://trac.webkit.org/changeset/135464>
WebKit Review Bot
Comment 4 2012-11-21 19:16:00 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2012-11-21 21:55:11 PST
(In reply to comment #3) > (From update of attachment 175553 [details]) > Clearing flags on attachment: 175553 > > Committed r135464: <http://trac.webkit.org/changeset/135464> It broke the GTK build as the EWS said ...
Hajime Morrita
Comment 6 2012-11-21 23:20:06 PST
(In reply to comment #5) > (In reply to comment #3) > > (From update of attachment 175553 [details] [details]) > > Clearing flags on attachment: 175553 > > > > Committed r135464: <http://trac.webkit.org/changeset/135464> > > It broke the GTK build as the EWS said ... Ooops. Will fix. Thanks for letting me know and I'm sorry for the breakage.
WebKit Review Bot
Comment 7 2012-11-21 23:28:31 PST
Re-opened since this is blocked by bug 103026
Hajime Morrita
Comment 8 2012-11-22 00:37:26 PST
Created attachment 175609 [details] Patch for landing
Hajime Morrita
Comment 9 2012-11-22 00:37:52 PST
Comment on attachment 175609 [details] Patch for landing Waiting gtk bot.
WebKit Review Bot
Comment 10 2012-11-25 17:15:00 PST
Comment on attachment 175609 [details] Patch for landing Rejecting attachment 175609 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14984457
Hajime Morrita
Comment 11 2012-11-25 17:47:45 PST
Created attachment 175904 [details] Patch for landing
WebKit Review Bot
Comment 12 2012-11-26 01:39:30 PST
Comment on attachment 175904 [details] Patch for landing Clearing flags on attachment: 175904 Committed r135693: <http://trac.webkit.org/changeset/135693>
WebKit Review Bot
Comment 13 2012-11-26 01:39:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.