Bug 102553

Summary: [v8] Minimal fix for MutationObserver memory leak
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, esprehn, haraken, japhet, rafaelw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+

Adam Klein
Reported 2012-11-16 12:57:08 PST
[v8] Minimal fix for MutationObserver memory leak
Attachments
Patch (13.83 KB, patch)
2012-11-16 12:57 PST, Adam Klein 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2012-11-16 12:57:42 PST
Created attachment 174748 [details] Patch
Adam Klein
Comment 2 2012-11-16 13:03:35 PST
This is based on esprehn's patch in https://bugs.webkit.org/show_bug.cgi?id=93661, but with all non-V8 and non-essential stuff ripped out. Hopefully small enough to be merged into beta/stable if we need to.
Adam Barth
Comment 3 2012-11-16 13:33:28 PST
Comment on attachment 174748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174748&action=review > Source/WebCore/bindings/v8/V8MutationCallback.cpp:85 > + if (!observerHandle->IsObject()) > + return true; Can this case actually occur?
Adam Klein
Comment 4 2012-11-16 13:54:56 PST
I think https://bugs.webkit.org/show_bug.cgi?id=102555 is a better (and more minimal) approach to the same problem.
Adam Barth
Comment 5 2012-11-16 14:12:35 PST
Yeah, I agree. *** This bug has been marked as a duplicate of bug 102555 ***
Note You need to log in before you can comment on or make changes to this bug.