Bug 102288

Summary: IndexedDB: Add clear() method to JSC ScriptValue
Product: WebKit Reporter: Michael Pruett <michael>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, haraken, jsbell, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 45110    
Attachments:
Description Flags
Add clear() method to JSC ScriptValue
haraken: review+
Add clear() method to JSC ScriptValue none

Michael Pruett
Reported 2012-11-14 14:52:23 PST
IDBRequest::dispatchEvent() calls ScriptValue::clear(), which exists only in the V8 implementation of ScriptValue. This patch adds a clear() method to the JSC implementation of ScriptValue.
Attachments
Add clear() method to JSC ScriptValue (1.70 KB, patch)
2012-11-14 15:07 PST, Michael Pruett 		haraken: review+
DetailsFormatted DiffDiff
Add clear() method to JSC ScriptValue (1.67 KB, patch)
2012-11-14 15:57 PST, Michael Pruett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Pruett
Comment 1 2012-11-14 15:07:08 PST
Created attachment 174267 [details] Add clear() method to JSC ScriptValue
Kentaro Hara
Comment 2 2012-11-14 15:47:20 PST
Comment on attachment 174267 [details] Add clear() method to JSC ScriptValue View in context: https://bugs.webkit.org/attachment.cgi?id=174267&action=review > Source/WebCore/bindings/js/ScriptValue.h:66 > + void clear() > + { > + m_value.clear(); > + } Nit: you can write it in one line.
Michael Pruett
Comment 3 2012-11-14 15:57:03 PST
Created attachment 174276 [details] Add clear() method to JSC ScriptValue
Kentaro Hara
Comment 4 2012-11-14 16:02:41 PST
Comment on attachment 174276 [details] Add clear() method to JSC ScriptValue thanks
WebKit Review Bot
Comment 5 2012-11-14 16:24:28 PST
Comment on attachment 174276 [details] Add clear() method to JSC ScriptValue Clearing flags on attachment: 174276 Committed r134689: <http://trac.webkit.org/changeset/134689>
WebKit Review Bot
Comment 6 2012-11-14 16:24:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.