Bug 102059

Summary: [EFL] rebaseline after bug 98666 (input[type=range] thumb rendering)
Product: WebKit Reporter: Jussi Kukkonen (jku) <jussi.kukkonen>
Component: Tools / TestsAssignee: Jussi Kukkonen (jku) <jussi.kukkonen>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, gyuyoung.kim, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98666    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Jussi Kukkonen (jku)
Reported 2012-11-13 01:25:14 PST
I'll rebaseline these. There seem to be several rendering differences though, this will take a moment. webkit.org/b/98666 fast/dom/HTMLInputElement/input-slider-update.html [ Failure ] webkit.org/b/98666 fast/dom/HTMLInputElement/input-slider-update-styled.html [ Failure ] webkit.org/b/98666 fast/forms/box-shadow-override.html [ Failure ] webkit.org/b/98666 fast/forms/input-appearance-height.html [ Failure ] webkit.org/b/98666 fast/forms/range/input-appearance-range.html [ Failure ] webkit.org/b/98666 fast/forms/range/range-thumb-height-percentage.html [ Failure ] webkit.org/b/98666 fast/forms/range/slider-padding.html [ Failure ] webkit.org/b/98666 fast/forms/range/slider-thumb-shared-style.html [ Failure ] webkit.org/b/98666 fast/forms/range/slider-thumb-stylability.html [ Failure ] webkit.org/b/98666 fast/multicol/client-rects.html [ Failure ] webkit.org/b/98666 fast/repaint/slider-thumb-drag-release.html [ Failure ] webkit.org/b/98666 fast/repaint/slider-thumb-float.html [ Failure ] webkit.org/b/98666 fast/layers/video-layer.html [ Failure ] webkit.org/b/98666 media/media-controls-clone.html [ Failure ] webkit.org/b/98666 media/media-document-audio-repaint.html [ Failure ] webkit.org/b/98666 media/track/track-cue-rendering-horizontal.html [ Failure ] webkit.org/b/98666 media/video-display-toggle.html [ Failure ] webkit.org/b/98666 media/video-empty-source.html [ Failure ] webkit.org/b/98666 media/video-no-audio.html [ Failure ] webkit.org/b/98666 media/video-zoom-controls.html [ Failure ] webkit.org/b/98666 media/track/track-cue-rendering-vertical.html [ Failure ] webkit.org/b/98666 media/audio-controls-rendering.html [ Failure ] webkit.org/b/98666 media/audio-repaint.html [ Failure ] webkit.org/b/98666 media/controls-after-reload.html [ Failure ] webkit.org/b/98666 media/controls-strict.html [ Failure ] webkit.org/b/98666 media/controls-styling.html [ Failure ] webkit.org/b/98666 media/controls-styling-strict.html [ Failure ] webkit.org/b/98666 media/controls-without-preload.html [ Failure ]
Attachments
Patch (61.70 KB, patch)
2012-11-13 04:57 PST, Jussi Kukkonen (jku) 		no flags
DetailsFormatted DiffDiff
Patch (62.95 KB, patch)
2012-11-13 05:52 PST, Jussi Kukkonen (jku) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jussi Kukkonen (jku)
Comment 1 2012-11-13 04:57:42 PST
Created attachment 173866 [details] Patch
Jussi Kukkonen (jku)
Comment 2 2012-11-13 05:00:59 PST
(In reply to comment #1) > Created an attachment (id=173866) [details] > Patch One comment on this: I updated a couple of generic (non-platform) results, these weren't changed so far because most ports have port specific results even if they match the generic ones... The results seemed correct so I didn't see a reason to add platform results for efl.
Jussi Kukkonen (jku)
Comment 3 2012-11-13 05:35:57 PST
Comment on attachment 173866 [details] Patch missed one new result, new patch coming up.
Jussi Kukkonen (jku)
Comment 4 2012-11-13 05:52:15 PST
Created attachment 173880 [details] Patch
WebKit Review Bot
Comment 5 2012-11-13 06:37:39 PST
Comment on attachment 173880 [details] Patch Rejecting attachment 173880 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: yle/checkers/python.py", line 31, in <module> from webkitpy.thirdparty.autoinstalled.pylint import lint File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module> from pylint.checkers import utils File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module> from logilab.astng.utils import ASTWalker ImportError: No module named logilab.astng.utils Full output: http://queues.webkit.org/results/14823414
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-11-13 07:31:05 PST
Comment on attachment 173880 [details] Patch Clearing flags on attachment: 173880 Committed r134416: <http://trac.webkit.org/changeset/134416>
Raphael Kubo da Costa (:rakuco)
Comment 7 2012-11-13 07:31:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.