Bug 101703

Summary: [Refactoring] Remove shadowPseudoId() and use pseudo() instead in <progress> ElementShadow
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, ojan, philn, webcomponents-bugzilla, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101171    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Shinya Kawanaka
Reported 2012-11-08 21:33:16 PST
We would like to remove shadowPseudoId, and use pseudo() instead.
Attachments
Patch (4.91 KB, patch)
2012-11-12 21:31 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (4.92 KB, patch)
2012-11-12 21:33 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (4.73 KB, patch)
2012-11-12 21:50 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.73 KB, patch)
2012-11-12 21:52 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.25 KB, patch)
2012-11-19 19:03 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-12 21:31:16 PST
Created attachment 173811 [details] Patch
Shinya Kawanaka
Comment 2 2012-11-12 21:33:24 PST
Created attachment 173812 [details] Patch
Early Warning System Bot
Comment 3 2012-11-12 21:37:52 PST
Comment on attachment 173812 [details] Patch Attachment 173812 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14825077
Early Warning System Bot
Comment 4 2012-11-12 21:38:58 PST
Comment on attachment 173812 [details] Patch Attachment 173812 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14813630
Hajime Morrita
Comment 5 2012-11-12 21:48:50 PST
Comment on attachment 173812 [details] Patch The change looks trivial. Let's ensure all green.
Shinya Kawanaka
Comment 6 2012-11-12 21:50:32 PST
Created attachment 173817 [details] Patch
Shinya Kawanaka
Comment 7 2012-11-12 21:52:35 PST
Created attachment 173819 [details] Patch for landing
Build Bot
Comment 8 2012-11-13 06:31:56 PST
Comment on attachment 173819 [details] Patch for landing Attachment 173819 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14811847 New failing tests: editing/style/apply-style-atomic.html fast/dom/HTMLProgressElement/progress-element-markup.html
WebKit Review Bot
Comment 9 2012-11-13 09:52:27 PST
Comment on attachment 173819 [details] Patch for landing Attachment 173819 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14822465 New failing tests: editing/style/apply-style-atomic.html fast/dom/HTMLProgressElement/progress-element-markup.html
Shinya Kawanaka
Comment 10 2012-11-19 18:34:16 PST
Oops... this has not been landed... :-\
Shinya Kawanaka
Comment 11 2012-11-19 19:03:36 PST
Created attachment 175114 [details] Patch for landing
WebKit Review Bot
Comment 12 2012-11-19 21:50:24 PST
Comment on attachment 175114 [details] Patch for landing Clearing flags on attachment: 175114 Committed r135249: <http://trac.webkit.org/changeset/135249>
WebKit Review Bot
Comment 13 2012-11-19 21:50:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.