Bug 101698

Summary: Changing pseudoClass :link should invalidate distribution.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tkent, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100451    
Attachments:
Description Flags
WIP
none
Patch none

Shinya Kawanaka
Reported 2012-11-08 20:49:05 PST
When pseudoClass :link is changed, we should invalidate distribution.
Attachments
WIP (18.13 KB, patch)
2012-11-13 01:25 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (7.56 KB, patch)
2012-11-14 18:22 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-13 00:58:34 PST
spec says :link should match <link href="...">, but maybe we don't support it yet? http://www.whatwg.org/specs/web-apps/current-work/multipage/selectors.html#selector-link
Shinya Kawanaka
Comment 2 2012-11-13 01:25:51 PST
Created attachment 173849 [details] WIP
Shinya Kawanaka
Comment 3 2012-11-13 01:26:19 PST
Almost done. We have to have a test for <area>
Shinya Kawanaka
Comment 4 2012-11-14 18:22:03 PST
Created attachment 174311 [details] Patch
Hajime Morrita
Comment 5 2012-11-14 19:02:03 PST
Comment on attachment 174311 [details] Patch Looks good. By the way, It looks invalidateParentDistribution... is often called with setNeedsStyleRecalc() Do you think it is good idea to get them together somehow?
WebKit Review Bot
Comment 6 2012-11-14 19:18:30 PST
Comment on attachment 174311 [details] Patch Clearing flags on attachment: 174311 Committed r134727: <http://trac.webkit.org/changeset/134727>
WebKit Review Bot
Comment 7 2012-11-14 19:18:34 PST
All reviewed patches have been landed. Closing bug.
Shinya Kawanaka
Comment 8 2012-11-14 19:46:54 PST
(In reply to comment #5) > (From update of attachment 174311 [details]) > Looks good. By the way, It looks invalidateParentDistribution... is often called with setNeedsStyleRecalc() > Do you think it is good idea to get them together somehow? It seems good to have a utility method to call them.
Note You need to log in before you can comment on or make changes to this bug.