Bug 101551

Summary: [chromium] Should pass fast/images/paletted-png-with-color-profile.html
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: ImagesAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cevans, hclam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.libpng.org/pub/png/colorcube/colorcube-pngs-iCCP-CSS.html
Bug Depends on: 86722    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch
none
test page in chrome 24 mac none

noel gordon
Reported 2012-11-07 23:33:54 PST
I added fast/images/paletted-png-with-color-profile.html in bug 86722, and chromium should pass this test.
Attachments
Patch (6.34 KB, patch)
2012-11-07 23:49 PST, noel gordon
no flags
Patch (7.62 KB, patch)
2012-11-08 03:40 PST, noel gordon
no flags
Patch for landing (7.52 KB, patch)
2012-11-08 20:57 PST, noel gordon
no flags
Patch (7.58 KB, patch)
2012-11-09 05:07 PST, noel gordon
no flags
test page in chrome 24 mac (49.46 KB, image/png)
2012-11-11 20:13 PST, noel gordon
no flags
noel gordon
Comment 1 2012-11-07 23:49:28 PST
WebKit Review Bot
Comment 2 2012-11-07 23:51:58 PST
Attachment 172941 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:360: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
noel gordon
Comment 3 2012-11-08 03:40:43 PST
noel gordon
Comment 4 2012-11-08 20:57:48 PST
Created attachment 173189 [details] Patch for landing
noel gordon
Comment 5 2012-11-09 05:07:57 PST
WebKit Review Bot
Comment 6 2012-11-09 17:26:36 PST
Comment on attachment 173270 [details] Patch Clearing flags on attachment: 173270 Committed r134138: <http://trac.webkit.org/changeset/134138>
WebKit Review Bot
Comment 7 2012-11-09 17:26:40 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 8 2012-11-09 20:17:45 PST
+hclam, platform/chromium/virtual/deferred/fast/images/paletted-png-with-color-profile.html may need an update. Please note we only support color profiles on chrome win/mac.
noel gordon
Comment 9 2012-11-11 20:13:12 PST
Created attachment 173543 [details] test page in chrome 24 mac How we looked in chrome 24 mac for reference. With this CL, we better match FireFox on win and mac, and Safari mac. The test page looks somewhat imperfect in mac browsers (chrome safari firefox) /shrug
Note You need to log in before you can comment on or make changes to this bug.