Bug 101424

Summary: Coordinated Graphics: Remove an invisible TiledBackingStore of CoordinatedGraphicsLayer.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: Layout and RenderingAssignee: Dongseong Hwang <dongseong.hwang>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, helder.correia, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101023    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dongseong Hwang
Reported 2012-11-06 20:12:33 PST
I found a bug in http://www.satine.org/research/webkit/snowleopard/snowstack.html When we push space, the selected image zooms in. And then when we push space one more time, we can see two images: one image is zooming out and another lays behind. We must remove the behind image. I assume that the owner div of an image element draws the image although the div is not drawsContent.
Attachments
Patch (8.07 KB, patch)
2012-11-07 01:36 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (29.31 KB, patch)
2012-11-08 03:15 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Patch (29.47 KB, patch)
2012-11-08 13:36 PST, Dongseong Hwang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dongseong Hwang
Comment 1 2012-11-06 20:13:50 PST
This bug is not reproduced in WebKit1. It is a Coordinated Graphics bug.
Dongseong Hwang
Comment 2 2012-11-07 01:36:12 PST
Created attachment 172737 [details] Patch
Noam Rosenthal
Comment 3 2012-11-07 05:05:29 PST
Comment on attachment 172737 [details] Patch How is this tested?
Dongseong Hwang
Comment 4 2012-11-07 15:31:46 PST
(In reply to comment #3) > (From update of attachment 172737 [details]) > How is this tested? I'll make a layout test extracting from snowstack.html.
Dongseong Hwang
Comment 5 2012-11-08 03:15:14 PST
Created attachment 172983 [details] Patch
Dongseong Hwang
Comment 6 2012-11-08 03:22:22 PST
(In reply to comment #5) > Created an attachment (id=172983) [details] > Patch I fix this bug in the correct way. Previous patch fixed the bug by change. In detail, TextureMapperLayer had m_backingStore although m_size is empty. TextureMapperLayer called m_backingStore->paintToTextureMapper(options.textureMapper, layerRect(),) in paintSelf. The previous patch made CoordinatedBackingStore not draw anything when targetRect (layerRect() above) is empty. So the bug disappeared. The second patch fixes the root. However, I need CoordinatedBackingStore::paintToTextureMapper to act like TextureMapperSurfaceBackingStore and TextureMapperTiledBackingStore in order for a direct composited image to use CoordinatedBackingStore. I'll change this in another bug.
Dongseong Hwang
Comment 7 2012-11-08 03:24:11 PST
(In reply to comment #5) > Created an attachment (id=172983) [details] > Patch Currently, we store an invisible TBS, so we waste heap and video memory.
WebKit Review Bot
Comment 8 2012-11-08 08:00:26 PST
Comment on attachment 172983 [details] Patch Rejecting attachment 172983 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: return self.open(self.click(*args, **kwds)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://queues.webkit.org/results/14764621
Helder Correia
Comment 9 2012-11-08 10:57:06 PST
I think you should add #include <wtf/HashSet.h> at the top of CoordinatedBackingStore.h.
WebKit Review Bot
Comment 10 2012-11-08 12:22:44 PST
Comment on attachment 172983 [details] Patch Attachment 172983 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14762784 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Dongseong Hwang
Comment 11 2012-11-08 13:32:05 PST
(In reply to comment #9) > I think you should add #include <wtf/HashSet.h> at the top of CoordinatedBackingStore.h. Thank you very much!
Dongseong Hwang
Comment 12 2012-11-08 13:36:50 PST
Created attachment 173109 [details] Patch
Dongseong Hwang
Comment 13 2012-11-08 13:39:56 PST
(In reply to comment #12) > Created an attachment (id=173109) [details] > Patch wow, so fast. Thank you!
WebKit Review Bot
Comment 14 2012-11-08 14:38:26 PST
Comment on attachment 173109 [details] Patch Clearing flags on attachment: 173109 Committed r133955: <http://trac.webkit.org/changeset/133955>
WebKit Review Bot
Comment 15 2012-11-08 14:38:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.