Bug 100704

Summary: [CSS Exclusions] Clean up shape-inside tests' subpixel snapping code
Product: WebKit Reporter: Bear Travis <betravis>
Component: CSSAssignee: Bear Travis <betravis>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, donggwan.kim, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100307    
Attachments:
Description Flags
initial patch
none
Factoring out subpixel test code to separate file
none
Adding polygon tests
none
Updating patch
none
refactoring subpixel rounding into the .js file none

Bear Travis
Reported 2012-10-29 15:10:44 PDT
Layout pixel snaps the position of segments for shape-inside. Modify the rounded rectangle tests to use the same pixel snapping as the polygon tests. In sub-pixel layout, the result may be slightly different.
Attachments
initial patch (3.20 KB, patch)
2012-10-29 15:15 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Factoring out subpixel test code to separate file (13.63 KB, patch)
2012-10-30 13:24 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Adding polygon tests (25.96 KB, patch)
2012-10-30 14:13 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Updating patch (26.08 KB, patch)
2012-11-01 12:04 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
refactoring subpixel rounding into the .js file (23.92 KB, patch)
2012-11-02 11:50 PDT, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2012-10-29 15:15:32 PDT
Created attachment 171321 [details] initial patch
Bear Travis
Comment 2 2012-10-30 13:24:12 PDT
Created attachment 171511 [details] Factoring out subpixel test code to separate file
Bear Travis
Comment 3 2012-10-30 13:54:09 PDT
Modifying bug to cover factoring subpixel code out of polygon tests as well.
Bear Travis
Comment 4 2012-10-30 14:13:24 PDT
Created attachment 171518 [details] Adding polygon tests
WebKit Review Bot
Comment 5 2012-10-30 19:09:40 PDT
Comment on attachment 171518 [details] Adding polygon tests Attachment 171518 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14662059 New failing tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html
Dirk Schulze
Comment 6 2012-10-31 05:59:07 PDT
Comment on attachment 171518 [details] Adding polygon tests Can you investigate why one of the exclusion tests is failing please? Does subPixelLayoutEnabled() not help here? Is it another problem and we need to skip it?
Bear Travis
Comment 7 2012-11-01 12:04:35 PDT
Created attachment 171905 [details] Updating patch Forgot to pass along the subpixel argument when generating tests.
Bear Travis
Comment 8 2012-11-02 11:50:30 PDT
Created attachment 172099 [details] refactoring subpixel rounding into the .js file
Dirk Schulze
Comment 9 2012-11-02 17:54:28 PDT
Comment on attachment 172099 [details] refactoring subpixel rounding into the .js file LGTM. r=me.
WebKit Review Bot
Comment 10 2012-11-02 18:22:17 PDT
Comment on attachment 172099 [details] refactoring subpixel rounding into the .js file Clearing flags on attachment: 172099 Committed r133384: <http://trac.webkit.org/changeset/133384>
WebKit Review Bot
Comment 11 2012-11-02 18:22:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.