Bug 100661
| Summary: | [Qt][WK2] REGRESSION(r132640): It made tst_QQuickWebView::removeFromCanvas() timeout. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Blocker | CC: | jturcotte, kenneth, ossy |
| Priority: | P1 | Keywords: | Qt, QtTriaged |
| Version: | 420+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 70236, 76773, 100495 | ||
Csaba Osztrogonác
After https://trac.webkit.org/changeset/132640 tst_QQuickWebView::removeFromCanvas()
started to fail with timeout:
********* Start testing of tst_QQuickWebView *********
Config: Using QTest library 5.0.0, Qt 5.0.0
...
QFATAL : tst_QQuickWebView::removeFromCanvas() Received signal 15
FAIL! : tst_QQuickWebView::removeFromCanvas() Received a fatal error.
Loc: [Unknown file(0)]
Totals: 16 passed, 1 failed, 0 skipped
********* Finished testing of tst_QQuickWebView *********
I tried to revert r132640 locally, and then this test case always passes,
but another test case started to fail later:
********* Start testing of tst_QQuickWebView *********
Config: Using QTest library 5.0.0, Qt 5.0.0
...
PASS : tst_QQuickWebView::removeFromCanvas()
...
QFATAL : tst_QQuickWebView::basicRenderingSanity() Received signal 11
FAIL! : tst_QQuickWebView::basicRenderingSanity() Received a fatal error.
Loc: [Unknown file(0)]
Totals: 23 passed, 1 failed, 0 skipped
********* Finished testing of tst_QQuickWebView *********
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jocelyn Turcotte
(In reply to comment #0)
Yep it was a fix for basicRenderingSanity but all tests seemed to pass on my desktop. I'm seeing another case where directly composited images are causing a crash, I'll check if I can fix removeFromCanvas too.
Jocelyn Turcotte
Arf, webkit-patch reopened the other bug and used it for the patch for some reason.
Anyway, it got fixed in <http://trac.webkit.org/changeset/132801>
Resolving as duplicate even though this is the bug written in the ChangeLog.
*** This bug has been marked as a duplicate of bug 100672 ***
Csaba Osztrogonác
I really don't understand why you always file one more bug report ... :)
Why wasn't it good for you to fix the bug?
Csaba Osztrogonác
I meant changing the title of the bug.
Jocelyn Turcotte
(In reply to comment #3)
> I really don't understand why you always file one more bug report ... :)
> Why wasn't it good for you to fix the bug?
Nah I didn't want to this time, but webkit-patch creates one automatically except when running prepare-changelogs beforehand. Just forgot and then I probably didn't restart it after having closed the bug and changed the bug url in the changelog.