Bug 100472

Summary: [EFL][WK2] Add Ewk_Color_Picker API
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, mikhail.pozdnyakov, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100226    
Attachments:
Description Flags
Patch
kenneth: review+, cdumez: commit-queue-
Patch for landing
webkit.review.bot: commit-queue-
Patch for landing none

Chris Dumez
Reported 2012-10-26 00:00:55 PDT
We should move the color picker code out of EwkView and into a new Ewk_Color_Picker class to avoid cluttering the view code.
Attachments
Patch (28.67 KB, patch)
2012-10-26 03:11 PDT, Chris Dumez 		kenneth: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (28.70 KB, patch)
2012-10-26 03:23 PDT, Chris Dumez 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (28.76 KB, patch)
2012-10-26 03:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-26 03:11:17 PDT
Created attachment 170865 [details] Patch
Chris Dumez
Comment 2 2012-10-26 03:18:45 PDT
Comment on attachment 170865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170865&action=review > Source/WebKit2/UIProcess/API/efl/ewk_color_picker.h:61 > +EAPI Eina_Bool ewk_color_picker_color_get(Ewk_Color_Picker *color_picker, int *r, int *g, int *b, int *a); Oops, argument should be const.
Chris Dumez
Comment 3 2012-10-26 03:23:19 PDT
Created attachment 170867 [details] Patch for landing Marked the getter argument as const, as per WebKitEFL coding style. Sorry about that. Could someone please cq+?
WebKit Review Bot
Comment 4 2012-10-26 03:25:49 PDT
Comment on attachment 170867 [details] Patch for landing Rejecting attachment 170867 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: I/efl/ewk_color_picker_private.h patching file Source/WebKit2/UIProcess/API/efl/ewk_view.cpp patching file Source/WebKit2/UIProcess/API/efl/ewk_view.h patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp patching file Source/WebKit2/UIProcess/efl/PageUIClientEfl.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14566995
Chris Dumez
Comment 5 2012-10-26 03:32:19 PDT
Created attachment 170872 [details] Patch for landing Rebased on master.
WebKit Review Bot
Comment 6 2012-10-26 04:32:40 PDT
Comment on attachment 170872 [details] Patch for landing Clearing flags on attachment: 170872 Committed r132617: <http://trac.webkit.org/changeset/132617>
WebKit Review Bot
Comment 7 2012-10-26 04:32:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.