Bug 100342

Summary: [WK2] Use per destination ID message receivers for DownloadProxy.
Product: WebKit Reporter: Byungwoo Lee <bw80.lee>
Component: WebKit2Assignee: Byungwoo Lee <bw80.lee>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, kenneth, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100310    
Attachments:
Description Flags
Patch
none
Patch none

Byungwoo Lee
Reported 2012-10-25 00:13:22 PDT
There is below assertion after r132386 when dispatching ipc message about DownloadProxy. ASSERTION FAILED: !decoder.destinationID() /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit2/Platform/CoreIPC/MessageReceiverMap.cpp(79) : bool CoreIPC::MessageReceiverMap::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) To fix the assertion problem, adding/removing messageReceiver for DownloadProxy need to use new addMessageReceiver() function with downloadID for destinationID parameter.
Attachments
Patch (4.35 KB, patch)
2012-10-25 00:26 PDT, Byungwoo Lee 		no flags
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2012-10-25 02:51 PDT, Byungwoo Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Byungwoo Lee
Comment 1 2012-10-25 00:26:49 PDT
Created attachment 170569 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-10-25 00:40:37 PDT
Comment on attachment 170569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170569&action=review > Source/WebKit2/ChangeLog:8 > + Per destination ID message receivers are proposed at r132386. in r... not at > Source/WebKit2/ChangeLog:10 > + so the messages should be handled by per destination ID message receivers. by per sounds weird. by?
Byungwoo Lee
Comment 3 2012-10-25 00:44:15 PDT
(In reply to comment #2) > (From update of attachment 170569 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170569&action=review > > > Source/WebKit2/ChangeLog:8 > > + Per destination ID message receivers are proposed at r132386. > > in r... not at Ok. I'll change it. > > > Source/WebKit2/ChangeLog:10 > > + so the messages should be handled by per destination ID message receivers. > > by per sounds weird. by? How about this? 'so the messages should be handled by the message receivers that is newly proposed.'
Chris Dumez
Comment 4 2012-10-25 00:48:50 PDT
Comment on attachment 170569 [details] Patch Looks reasonable to me but it would be nice if Andersca took a look.
Byungwoo Lee
Comment 5 2012-10-25 02:51:09 PDT
Created attachment 170598 [details] Patch
Byungwoo Lee
Comment 6 2012-10-25 02:53:04 PDT
Applied the comments from kenneth.
Anders Carlsson
Comment 7 2012-10-25 08:45:16 PDT
Comment on attachment 170598 [details] Patch Looks great! r=me.
Byungwoo Lee
Comment 8 2012-10-25 17:19:31 PDT
Comment on attachment 170598 [details] Patch Thank you for the review :)
WebKit Review Bot
Comment 9 2012-10-25 18:03:05 PDT
Comment on attachment 170598 [details] Patch Clearing flags on attachment: 170598 Committed r132548: <http://trac.webkit.org/changeset/132548>
WebKit Review Bot
Comment 10 2012-10-25 18:03:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.