Attachment 371634 Details for Bug 198685 – Patch

[patch] Patch

bug-198685-20190607172814.patch (text/plain), 2.43 KB, created by Tim Horton on 2019-06-07 17:28:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2019-06-07 17:28:14 PDT

Size: 2.43 KB

patch

obsolete

>Subversion Revision: 246213
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 33b8ce837b7301bfd25493f2dd59e1a22d2d1ec3..19b006516eda2711a63aec9f2392d20d696509ba 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-07  Tim Horton  <timothy_horton@apple.com>
>+
>+        Disable focus rings on WKContentView for PLATFORM(IOSMAC)
>+        https://bugs.webkit.org/show_bug.cgi?id=198685
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Platform/spi/ios/UIKitSPI.h:
>+        * UIProcess/ios/WKContentView.mm:
>+        (-[WKContentView _commonInitializationWithProcessPool:configuration:]):
>+
> 2019-06-07  Antoine Quint  <graouts@apple.com>
> 
>         Restrict fast clicks everywhere to desktop content mode
>diff --git a/Source/WebKit/Platform/spi/ios/UIKitSPI.h b/Source/WebKit/Platform/spi/ios/UIKitSPI.h
>index 6ac2f639cacc140030aeb7b8c54c317ddcf938c7..3e57d4e30ad8a89e4745106f131a21fe533e0912 100644
>--- a/Source/WebKit/Platform/spi/ios/UIKitSPI.h
>+++ b/Source/WebKit/Platform/spi/ios/UIKitSPI.h
>@@ -514,6 +514,12 @@ typedef NS_ENUM (NSInteger, _UIBackdropMaskViewFlags) {
>     _UIBackdropMaskViewAll = _UIBackdropMaskViewGrayscaleTint | _UIBackdropMaskViewColorTint | _UIBackdropMaskViewFilters,
> };
> 
>+#if PLATFORM(IOSMAC)
>+typedef NS_ENUM(NSUInteger, UIFocusRingType) {
>+    UIFocusRingTypeNone = 1,
>+};
>+#endif
>+
> @interface UIView ()
> + (BOOL)_isInAnimationBlock;
> - (CGSize)size;
>@@ -528,6 +534,9 @@ typedef NS_ENUM (NSInteger, _UIBackdropMaskViewFlags) {
> - (CGSize)convertSize:(CGSize)size toView:(UIView *)view;
> - (void)_removeAllAnimations:(BOOL)includeSubviews;
> - (UIColor *)_inheritedInteractionTintColor;
>+#if PLATFORM(IOSMAC)
>+@property (nonatomic, getter=_focusRingType, setter=_setFocusRingType:) UIFocusRingType focusRingType;
>+#endif
> @end
> 
> @protocol UISelectionInteractionAssistant
>diff --git a/Source/WebKit/UIProcess/ios/WKContentView.mm b/Source/WebKit/UIProcess/ios/WKContentView.mm
>index 56b4562c796a714b9a0937d66828137b88b46923..dbd3227e758c8a6dc894387eb3222790f62af254 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentView.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentView.mm
>@@ -176,6 +176,10 @@ - (instancetype)_commonInitializationWithProcessPool:(WebKit::WebProcessPool&)pr
> 
>     self.layer.hitTestsAsOpaque = YES;
> 
>+#if PLATFORM(IOSMAC)
>+    [self _setFocusRingType:UIFocusRingTypeNone];
>+#endif
>+
> #if HAVE(VISIBILITY_PROPAGATION_VIEW)
>     [self _setupVisibilityPropagationView];
> #endif

Actions: View | Formatted Diff | Diff

Attachments on bug 198685: 371634