Attachment 371600 Details for Bug 198669 – Patch

[patch] Patch

bug-198669-20190607110120.patch (text/plain), 2.75 KB, created by youenn fablet on 2019-06-07 11:01:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-06-07 11:01:21 PDT

Size: 2.75 KB

patch

obsolete

>Subversion Revision: 246170
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 6f1a9fb8041e9eb673265d764a4058ef69d371f5..dd90efc6c6e9e0a23287ef2ebd134f636fb2f60f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2019-06-07  Youenn Fablet  <youenn@apple.com>
>+
>+        A MediaStreamTrack cannot modify whether being a capture track or not
>+        https://bugs.webkit.org/show_bug.cgi?id=198669
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a boolean in MediaStreamTrack to store whether a track is a capture one or not.
>+        This removes the need to always go through the private and its source.
>+        As a track might change of source (for non capture track cases), this
>+        also removes the possibility for a track to be capture and then no
>+        longer capture.
>+        No change of behavior.
>+        See also rdar://problem/49444622.
>+
>+        * Modules/mediastream/MediaStreamTrack.cpp:
>+        (WebCore::MediaStreamTrack::MediaStreamTrack):
>+        * Modules/mediastream/MediaStreamTrack.h:
>+        (WebCore::MediaStreamTrack::isCaptureTrack const):
>+
> 2019-06-07  Youenn Fablet  <youenn@apple.com>
> 
>         Add a RELEASE_ASSERT that removeAudioProducer should always be done in the main thread
>diff --git a/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp b/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
>index 8399d879bab569a04c55f6431c857e321ae249dd..9bc3cbf788922bbd4e5df265d0d6a5e795291e4c 100644
>--- a/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
>+++ b/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
>@@ -63,6 +63,7 @@ MediaStreamTrack::MediaStreamTrack(ScriptExecutionContext& context, Ref<MediaStr
>     , m_logIdentifier(uniqueLogIdentifier())
> #endif
>     , m_taskQueue(context)
>+    , m_isCaptureTrack(m_private->isCaptureTrack())
> {
>     ALWAYS_LOG(LOGIDENTIFIER);
>     suspendIfNeeded();
>diff --git a/Source/WebCore/Modules/mediastream/MediaStreamTrack.h b/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
>index de8b5a6f89fe88c44fa2c77638253c3086908331..155c723bdc9c9bd2360ba16232b2c34af593e985 100644
>--- a/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
>+++ b/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
>@@ -93,7 +93,7 @@ public:
>     enum class StopMode { Silently, PostEvent };
>     void stopTrack(StopMode = StopMode::Silently);
> 
>-    bool isCaptureTrack() const { return m_private->isCaptureTrack(); }
>+    bool isCaptureTrack() const { return m_isCaptureTrack; }
> 
>     struct TrackSettings {
>         Optional<int> width;
>@@ -202,6 +202,7 @@ private:
>     GenericTaskQueue<Timer> m_eventTaskQueue;
> 
>     bool m_ended { false };
>+    bool m_isCaptureTrack { false };
> };
> 
> typedef Vector<RefPtr<MediaStreamTrack>> MediaStreamTrackVector;

Actions: View | Formatted Diff | Diff

Attachments on bug 198669: 371600