Attachment 371544 Details for Bug 198637 – Patch

[patch] Patch

bug-198637-20190607034612.patch (text/plain), 3.20 KB, created by Alexey Shvayka on 2019-06-06 17:46:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Shvayka

Created: 2019-06-06 17:46:13 PDT

Size: 3.20 KB

patch

obsolete

>Index: JSTests/ChangeLog
>===================================================================
>--- JSTests/ChangeLog	(revision 246183)
>+++ JSTests/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-06-06  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Error message for non-callable Proxy `construct` trap is misleading
>+        https://bugs.webkit.org/show_bug.cgi?id=198637
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * stress/proxy-construct.js:
>+
> 2019-06-05  Justin Michaud  <justin_michaud@apple.com>
> 
>         [WASM-References] Add support for Anyref tables, Table.get and Table.set (for Anyref only).
>Index: JSTests/stress/proxy-construct.js
>===================================================================
>--- JSTests/stress/proxy-construct.js	(revision 246067)
>+++ JSTests/stress/proxy-construct.js	(working copy)
>@@ -15,7 +15,7 @@ function assert(b) {
>             new proxy;
>         } catch(e) {
>             threw = true;
>-            assert(e.toString() === "TypeError: 'construct' property of a Proxy's handler should be constructible");
>+            assert(e.toString() === "TypeError: 'construct' property of a Proxy's handler should be callable");
>         }
>         assert(threw);
>     }
>@@ -33,7 +33,7 @@ function assert(b) {
>             new proxy;
>         } catch(e) {
>             threw = true;
>-            assert(e.toString() === "TypeError: 'construct' property of a Proxy's handler should be constructible");
>+            assert(e.toString() === "TypeError: 'construct' property of a Proxy's handler should be callable");
>         }
>         assert(threw);
>     }
>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 246117)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-06-06  Alexey Shvayka  <shvaikalesh@gmail.com>
>+
>+        Error message for non-callable Proxy `construct` trap is misleading
>+        https://bugs.webkit.org/show_bug.cgi?id=198637
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Just like other traps, Proxy `construct` trap is invoked with [[Call]], not [[Construct]].
>+
>+        * runtime/ProxyObject.cpp:
>+        (JSC::performProxyConstruct): Tweak error message.
>+
> 2019-06-04  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Fix miscellaneous build warnings
>Index: Source/JavaScriptCore/runtime/ProxyObject.cpp
>===================================================================
>--- Source/JavaScriptCore/runtime/ProxyObject.cpp	(revision 246067)
>+++ Source/JavaScriptCore/runtime/ProxyObject.cpp	(working copy)
>@@ -571,7 +571,7 @@ static EncodedJSValue JSC_HOST_CALL perf
>     JSObject* handler = jsCast<JSObject*>(handlerValue);
>     CallData callData;
>     CallType callType;
>-    JSValue constructMethod = handler->getMethod(exec, callData, callType, makeIdentifier(vm, "construct"), "'construct' property of a Proxy's handler should be constructible"_s);
>+    JSValue constructMethod = handler->getMethod(exec, callData, callType, makeIdentifier(vm, "construct"), "'construct' property of a Proxy's handler should be callable"_s);
>     RETURN_IF_EXCEPTION(scope, encodedJSValue());
>     JSObject* target = proxy->target();
>     if (constructMethod.isUndefined()) {

Actions: View | Formatted Diff | Diff

Attachments on bug 198637: 371544 | 371575