Attachment 371414 Details for Bug 198571 – Patch

[patch] Patch

bug-198571-20190605095817.patch (text/plain), 2.03 KB, created by zalan on 2019-06-05 09:58:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2019-06-05 09:58:17 PDT

Size: 2.03 KB

patch

obsolete

>Subversion Revision: 246067
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index cf836839960695af3ba0fd72003df86729080094..3d317e351ad5fde31a8b4fb562c24760c1592468 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-06-05  Zalan Bujtas  <zalan@apple.com>
>+
>+        REGRESSION (~r244378) fast/events/touch/ios/content-observation/stuck-with-hover-state.html is flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=198571
>+        <rdar://problem/50349265>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        testRunner.notifyDone() is called prematurely.
>+
>+        * fast/events/touch/ios/content-observation/stuck-with-hover-state.html:
>+
> 2019-06-04  Antoine Quint  <graouts@apple.com>
> 
>         The "mouseenter" and "pointerenter" events are fired from the bottom up
>diff --git a/LayoutTests/fast/events/touch/ios/content-observation/stuck-with-hover-state.html b/LayoutTests/fast/events/touch/ios/content-observation/stuck-with-hover-state.html
>index 0b19b3f1ae67ae088daf112bd34f5a71cc66ec69..7037e15a983585a46e9609eae0d80ca4b2b44522 100644
>--- a/LayoutTests/fast/events/touch/ios/content-observation/stuck-with-hover-state.html
>+++ b/LayoutTests/fast/events/touch/ios/content-observation/stuck-with-hover-state.html
>@@ -24,9 +24,7 @@ async function test() {
>     let x = rect.left + rect.width / 2;
>     let y = rect.top + rect.height / 2;
> 
>-	await tapAtPoint(x, y);
>-
>-    setTimeout("testRunner.notifyDone()", 50);
>+    await tapAtPoint(x, y);
> }
> </script>
> </head>
>@@ -35,11 +33,13 @@ async function test() {
> <pre id=result></pre>
> <script>
> tapthis.addEventListener("mouseover", function( event ) {
>-	clearTimeout(setTimeout(function() { tapthis.innerHTML = "should not see this"; }, 50));
>+    clearTimeout(setTimeout(function() { tapthis.innerHTML = "should not see this"; }, 50));
> }, false);
> 
> tapthis.addEventListener("click", function( event ) {   
>-	result.innerHTML = "clicked";
>+    result.innerHTML = "clicked";
>+    if (window.testRunner)
>+        testRunner.notifyDone();
> }, false);
> </script>
> </body>

Actions: View | Formatted Diff | Diff

Attachments on bug 198571: 371414