WebKit Bugzilla
Attachment 371389 Details for
Bug 198561
: REGRESSION(r243094): [GTK][WPE] Stale content after restoring the web view session
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
wk2-state-session.diff (text/plain), 1.96 KB, created by
Carlos Garcia Campos
on 2019-06-05 05:10:11 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Carlos Garcia Campos
Created:
2019-06-05 05:10:11 PDT
Size:
1.96 KB
patch
obsolete
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index d54692625f4..975113edb98 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,21 @@ >+2019-06-05 Carlos Garcia Campos <cgarcia@igalia.com> >+ >+ REGRESSION(r243094): [GTK][WPE] Stale content after restoring the web view session >+ https://bugs.webkit.org/show_bug.cgi?id=198561 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ This is another regression of delaying the web process launch until the first load. If the session is restored >+ before anything has been loaded, which is the normal way, the RestoreSession message is just ignored and the >+ state is sent to the WebPage on creation via creation parameters. The WebPage considers that restoring a session >+ from creation parameters only happens when re-launching a process after a crash or in case of process swap. In >+ those cases, the history item is not marked as restored from session. We need to ensure the session is restored >+ in the web process from the IPC message handler, by launching the initial process before the session is >+ restored. >+ >+ * UIProcess/API/glib/WebKitWebView.cpp: >+ (webkit_web_view_restore_session_state): >+ > 2019-06-05 Michael Catanzaro <mcatanzaro@igalia.com> > > REGRESSION(r245796): [WPE][GTK] Web process crash on startup >diff --git a/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp b/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp >index ceb90d73d83..6e0defcbce8 100644 >--- a/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp >+++ b/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp >@@ -4126,6 +4126,7 @@ void webkit_web_view_restore_session_state(WebKitWebView* webView, WebKitWebView > g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView)); > g_return_if_fail(state); > >+ getPage(webView).launchInitialProcessIfNecessary(); > getPage(webView).restoreFromSessionState(webkitWebViewSessionStateGetSessionState(state), false); > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198561
:
371389
|
371476