Attachment 371377 Details for Bug 198556 – Fixes the bug

[patch] Fixes the bug

bug-198556-20190604223045.patch (text/plain), 2.25 KB, created by Ryosuke Niwa on 2019-06-04 22:30:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2019-06-04 22:30:45 PDT

Size: 2.25 KB

patch

obsolete

>Subversion Revision: 246095
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d6f7a003498a64ad8fe2546a67254218032faef1..8f59fdb7ec67ac6a9d363bdcc45362913f3f1589 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-06-04  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        iPadOS: Google calendars new event picker moves and flickers in landscape with software keyboard
>+        https://bugs.webkit.org/show_bug.cgi?id=198556
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix the issuse that it's really hard to create a new event using Google calendar on iPadOS with
>+        a software keyboard enabled because tapping on date brings up software keyboard and erratically
>+        shifts up/down the new event dialog/pane.
>+
>+        Add a site specific quirk to pretend these input elements have inputmode=none for now.
>+
>+        No new tests since this is a site specific quirk.
>+
>+        * page/Quirks.cpp:
>+        (WebCore::Quirks::needsInputModeNoneImplicitly const):
>+
> 2019-06-04  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         Fix miscellaneous build warnings
>diff --git a/Source/WebCore/page/Quirks.cpp b/Source/WebCore/page/Quirks.cpp
>index 2f571379447909e59c7a7327c11b4eefee25579b..9a3f3ac03ff680d8c553c9dd266bc82521129d3a 100644
>--- a/Source/WebCore/page/Quirks.cpp
>+++ b/Source/WebCore/page/Quirks.cpp
>@@ -338,6 +338,17 @@ bool Quirks::needsInputModeNoneImplicitly(const HTMLElement& element) const
>     if (!needsQuirks())
>         return false;
> 
>+    if (element.hasTagName(HTMLNames::inputTag)) {
>+        if (!equalLettersIgnoringASCIICase(m_document->url().host(), "calendar.google.com"))
>+            return false;
>+        static NeverDestroyed<QualifiedName> dataInitialValueAttr(nullAtom(), "data-initial-value", nullAtom());
>+        static NeverDestroyed<QualifiedName> dataPreviousValueAttr(nullAtom(), "data-previous-value", nullAtom());
>+
>+        return equalLettersIgnoringASCIICase(element.attributeWithoutSynchronization(HTMLNames::autocompleteAttr), "off")
>+            && element.hasAttributeWithoutSynchronization(dataInitialValueAttr)
>+            && element.hasAttributeWithoutSynchronization(dataPreviousValueAttr);
>+    }
>+
>     if (!element.hasTagName(HTMLNames::textareaTag))
>         return false;
>

Flags:

wenson_hsieh: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198556: 371377