Attachment 371216 Details for Bug 198500 – Patch

[patch] Patch

bug-198500-20190603144609.patch (text/plain), 2.49 KB, created by Chris Dumez on 2019-06-03 14:46:10 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-06-03 14:46:10 PDT

Size: 2.49 KB

patch

obsolete

>Subversion Revision: 246036
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 71608b231e0c2065428ca716c14d7a664a5945c3..ecd2849fba0df61894b4d494af6a92966ac07615 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-06-03  Chris Dumez  <cdumez@apple.com>
>+
>+        Lazily construct the NetworkHTTPSUpgradeChecker
>+        https://bugs.webkit.org/show_bug.cgi?id=198500
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Lazily construct the NetworkHTTPSUpgradeChecker since the feature is off by default and this
>+        avoids unnecessarily opening its database in the common case.
>+
>+        * NetworkProcess/NetworkProcess.h:
>+        * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
>+        (WebKit::NetworkProcess::networkHTTPSUpgradeChecker):
>+
> 2019-06-03  Chris Dumez  <cdumez@apple.com>
> 
>         [iOS] Do not prevent app suspension for more than 20 seconds after getting backgrounded
>diff --git a/Source/WebKit/NetworkProcess/NetworkProcess.h b/Source/WebKit/NetworkProcess/NetworkProcess.h
>index 111635d2e2008122d7825bc96379ac8967da18e7..0e1dabd00ee4ca94e22b2d25e0c32fbbc4054fdd 100644
>--- a/Source/WebKit/NetworkProcess/NetworkProcess.h
>+++ b/Source/WebKit/NetworkProcess/NetworkProcess.h
>@@ -316,7 +316,7 @@ public:
> #endif
> 
> #if PLATFORM(COCOA)
>-    NetworkHTTPSUpgradeChecker& networkHTTPSUpgradeChecker() { return m_networkHTTPSUpgradeChecker; }
>+    NetworkHTTPSUpgradeChecker& networkHTTPSUpgradeChecker();
> #endif
> 
>     const String& uiProcessBundleIdentifier() const { return m_uiProcessBundleIdentifier; }
>@@ -546,7 +546,7 @@ private:
> #endif
> 
> #if PLATFORM(COCOA)
>-    NetworkHTTPSUpgradeChecker m_networkHTTPSUpgradeChecker;
>+    std::unique_ptr<NetworkHTTPSUpgradeChecker> m_networkHTTPSUpgradeChecker;
> #endif
> 
>     class StorageQuotaManagers {
>diff --git a/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm b/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
>index ead5e62eab8454b3ddf2f9cb6cebaf40c80f7ba2..bdefe9e4fa59006d5eb597bb7c05d361dd7918a6 100644
>--- a/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
>+++ b/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
>@@ -304,4 +304,11 @@ void NetworkProcess::platformProcessDidTransitionToForeground()
> {
> }
> 
>+NetworkHTTPSUpgradeChecker& NetworkProcess::networkHTTPSUpgradeChecker()
>+{
>+    if (!m_networkHTTPSUpgradeChecker)
>+        m_networkHTTPSUpgradeChecker = std::make_unique<NetworkHTTPSUpgradeChecker>();
>+    return *m_networkHTTPSUpgradeChecker;
>+}
>+
> } // namespace WebKit

Actions: View | Formatted Diff | Diff

Attachments on bug 198500: 371216