Attachment 371187 Details for Bug 198480 – Patch

[patch] Patch

wd-exec-name.diff (text/plain), 1.48 KB, created by Carlos Garcia Campos on 2019-06-03 06:21:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2019-06-03 06:21:31 PDT

Size: 1.48 KB

patch

obsolete

>diff --git a/Source/WebDriver/ChangeLog b/Source/WebDriver/ChangeLog
>index 24915ae176e..3016c1ce619 100644
>--- a/Source/WebDriver/ChangeLog
>+++ b/Source/WebDriver/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-03  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        REGRESSION(r245567): [GTK][WPE] [2.25.1] WebKitWebDriver gets installed as WebDriver
>+        https://bugs.webkit.org/show_bug.cgi?id=198480
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We are now using the WEBKIT_EXECUTABLE macro that uses target_OUTPUT_NAME variable, but we define
>+        taget_Process_OUTPUT_NAME.
>+
>+        * PlatformGTK.cmake:
>+        * PlatformWPE.cmake:
>+
> 2019-05-31  Don Olmstead  <don.olmstead@sony.com>
> 
>         [CMake] Add WebKit::WTF target
>diff --git a/Source/WebDriver/PlatformGTK.cmake b/Source/WebDriver/PlatformGTK.cmake
>index 8bc9a44d28e..b786aceafc6 100644
>--- a/Source/WebDriver/PlatformGTK.cmake
>+++ b/Source/WebDriver/PlatformGTK.cmake
>@@ -1,4 +1,4 @@
>-set(WebDriver_Process_OUTPUT_NAME WebKitWebDriver)
>+set(WebDriver_OUTPUT_NAME WebKitWebDriver)
> 
> add_definitions(-DLIBEXECDIR="${CMAKE_INSTALL_FULL_LIBEXECDIR}")
> 
>diff --git a/Source/WebDriver/PlatformWPE.cmake b/Source/WebDriver/PlatformWPE.cmake
>index bd3cd811bd4..3ee97316365 100644
>--- a/Source/WebDriver/PlatformWPE.cmake
>+++ b/Source/WebDriver/PlatformWPE.cmake
>@@ -1,4 +1,4 @@
>-set(WebDriver_Process_OUTPUT_NAME WPEWebDriver)
>+set(WebDriver_OUTPUT_NAME WPEWebDriver)
> 
> list(APPEND WebDriver_SYSTEM_INCLUDE_DIRECTORIES
>     "${GLIB_INCLUDE_DIRS}"

Flags:

mcatanzaro: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198480: 371187