Attachment 371170 Details for Bug 198470 – Patch

[patch] Patch

198470.diff (text/plain), 3.33 KB, created by Devin Rousso on 2019-06-02 16:58:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-02 16:58:19 PDT

Size: 3.33 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index dd7c0847f1f..0ed30061ca4 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-01  Devin Rousso  <drousso@apple.com>
>+
>+        Flaky Test: inspector/canvas/recording.html
>+        https://bugs.webkit.org/show_bug.cgi?id=198470
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * inspector/canvas/recording.html:
>+        Don't rely on `frameCount` to automatically stop the recording, as that's dependent on when
>+        the <canvas> paints and is less controllable/deterministic.
>+
> 2019-06-01  Simon Fraser  <simon.fraser@apple.com>
> 
>         Non-composited negative z-order children should not trigger creation of a foreground layer
>diff --git a/LayoutTests/inspector/canvas/recording.html b/LayoutTests/inspector/canvas/recording.html
>index 25c6fbc78c4..bee3fda975b 100644
>--- a/LayoutTests/inspector/canvas/recording.html
>+++ b/LayoutTests/inspector/canvas/recording.html
>@@ -44,11 +44,12 @@ function test() {
>             canvas.awaitEvent(WI.Canvas.Event.RecordingStarted)
>             .then((event) => {
>                 InspectorTest.evaluateInPage(`performActionsNaN()`);
>-            });
> 
>-            const frameCount = 1;
>-            CanvasAgent.startRecording(canvas.identifier, frameCount)
>+                canvas.stopRecording();
>+            })
>             .catch(reject);
>+
>+            canvas.startRecording();
>         },
>     });
> 
>@@ -56,8 +57,6 @@ function test() {
>         name: "Canvas.MultipleRecording",
>         description: "Check that multiple recordings are able to be started/stopped at the same time.",
>         test(resolve, reject) {
>-            const singleFrame = false;
>-
>             let canvases = WI.canvasManager.canvases;
>             InspectorTest.assert(canvases.length === 2, "There should be two canvas contexts.");
> 
>@@ -73,7 +72,8 @@ function test() {
> 
>                 InspectorTest.log("Stopping the recording of canvas 2...");
>                 canvases[1].stopRecording();
>-            });
>+            })
>+            .catch(reject);
> 
>             InspectorTest.awaitEvent("TestPage-performActionsMultiple")
>             .then((event) => {
>@@ -81,7 +81,8 @@ function test() {
> 
>                 InspectorTest.log("Stopping the recording of canvas 1...");
>                 canvases[0].stopRecording();
>-            });
>+            })
>+            .catch(reject);
> 
>             canvases[1].awaitEvent(WI.Canvas.Event.RecordingStarted)
>             .then((event) => {
>@@ -89,18 +90,20 @@ function test() {
> 
>                 InspectorTest.log("Performing actions...");
>                 InspectorTest.evaluateInPage(`performActionsMultiple()`);
>-            });
>+            })
>+            .catch(reject);
> 
>             canvases[0].awaitEvent(WI.Canvas.Event.RecordingStarted)
>             .then((event) => {
>                 InspectorTest.expectThat(canvases[0].recordingActive, "Recording started of canvas 1");
> 
>                 InspectorTest.log("Starting a recording of canvas 2...");
>-                canvases[1].startRecording(singleFrame);
>-            });
>+                canvases[1].startRecording();
>+            })
>+            .catch(reject);
> 
>             InspectorTest.log("Starting a recording of canvas 1...");
>-            canvases[0].startRecording(singleFrame);
>+            canvases[0].startRecording();
>         },
>     });
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198470: 371168 | 371170 | 371190