Attachment 371142 Details for Bug 198466 – Patch

[patch] Patch

bug-198466-20190602201504.patch (text/plain), 14.23 KB, created by Takashi Komori on 2019-06-02 04:17:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Takashi Komori

Created: 2019-06-02 04:17:30 PDT

Size: 14.23 KB

patch

obsolete

>Subversion Revision: 245940
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a368a5fe6fae518c82cb76f47c4a48b8a6d79f42..189c9d52064bc1cef39a9ed37bc80956cfcfda1f 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,29 @@
>+2019-06-02  Takashi Komori  <Takashi.Komori@sony.com>
>+
>+        [WinCairo] Layout tests related to inspector doesn't work.
>+        https://bugs.webkit.org/show_bug.cgi?id=198466
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Implement cpu and memory measuring functions for layout tests related to inspector.
>+
>+        Tests: inspector/memory/tracking.html
>+               inspector/cpu-profiler/tracking.html
>+
>+        * PlatformWinCairo.cmake:
>+        * page/ResourceUsageThread.h:
>+        * page/win/ResourceUsageOverlayWinCairo.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp.
>+        (WebCore::ResourceUsageOverlay::platformInitialize):
>+        (WebCore::ResourceUsageOverlay::platformDestroy):
>+        * page/win/ResourceUsageThreadWinCairo.cpp: Added.
>+        (WebCore::ResourceUsageThread::platformSaveStateBeforeStarting):
>+        (WebCore::fileTimeToUint64):
>+        (WebCore::getCurrentCpuTime):
>+        (WebCore::cpuUsage):
>+        (WebCore::memoryUsage):
>+        (WebCore::ResourceUsageThread::platformCollectCPUData):
>+        (WebCore::ResourceUsageThread::platformCollectMemoryData):
>+
> 2019-05-30  Andres Gonzalez  <andresg_22@apple.com>
> 
>         Inserting a newline in contenteditable causes two characters to be added instead of one
>diff --git a/Source/WebCore/PlatformWinCairo.cmake b/Source/WebCore/PlatformWinCairo.cmake
>index ed69d743ae599c8f20966ef9a3bb1faeac86dc42..a96d8a23ee64f4671c55220085a30034965c596c 100644
>--- a/Source/WebCore/PlatformWinCairo.cmake
>+++ b/Source/WebCore/PlatformWinCairo.cmake
>@@ -12,6 +12,8 @@ list(APPEND WebCore_PRIVATE_INCLUDE_DIRECTORIES
> 
> list(APPEND WebCore_SOURCES
>     page/win/FrameCairoWin.cpp
>+    page/win/ResourceUsageOverlayWinCairo.cpp
>+    page/win/ResourceUsageThreadWinCairo.cpp
> 
>     platform/graphics/GLContext.cpp
>     platform/graphics/PlatformDisplay.cpp
>diff --git a/Source/WebCore/page/ResourceUsageThread.h b/Source/WebCore/page/ResourceUsageThread.h
>index 35ae3f03be365ee8606fe49ee6b7cf2aac2d55fd..0e35ea292525ca7982f26f05bcdd345ce66db030 100644
>--- a/Source/WebCore/page/ResourceUsageThread.h
>+++ b/Source/WebCore/page/ResourceUsageThread.h
>@@ -72,7 +72,7 @@ private:
>     void recomputeCollectionMode();
> 
>     void createThreadIfNeeded();
>-    void threadBody();
>+    NO_RETURN void threadBody();
> 
>     void platformSaveStateBeforeStarting();
>     void platformCollectCPUData(JSC::VM*, ResourceUsageData&);
>diff --git a/Source/WebCore/page/win/ResourceUsageOverlayWinCairo.cpp b/Source/WebCore/page/win/ResourceUsageOverlayWinCairo.cpp
>new file mode 100644
>index 0000000000000000000000000000000000000000..018d81ddb8e2da651245c43fc56613c29f2d40a9
>--- /dev/null
>+++ b/Source/WebCore/page/win/ResourceUsageOverlayWinCairo.cpp
>@@ -0,0 +1,44 @@
>+/*
>+ * Copyright (C) 2017 Igalia S.L.
>+ * Copyright (C) 2019 Sony Interactive Entertainment Inc.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#include "config.h"
>+#include "ResourceUsageOverlay.h"
>+
>+#if ENABLE(RESOURCE_USAGE) && OS(WINDOWS)
>+
>+namespace WebCore {
>+
>+void ResourceUsageOverlay::platformInitialize()
>+{
>+}
>+
>+void ResourceUsageOverlay::platformDestroy()
>+{
>+}
>+
>+}
>+
>+#endif
>diff --git a/Source/WebCore/page/win/ResourceUsageThreadWinCairo.cpp b/Source/WebCore/page/win/ResourceUsageThreadWinCairo.cpp
>new file mode 100644
>index 0000000000000000000000000000000000000000..cb4f1a2e4f3d3fb1adb5c4238a9a4d041aad4a4d
>--- /dev/null
>+++ b/Source/WebCore/page/win/ResourceUsageThreadWinCairo.cpp
>@@ -0,0 +1,140 @@
>+/*
>+ * Copyright (C) 2017 Igalia S.L.
>+ * Copyright (C) 2018 Apple Inc. All rights reserved.
>+ * Copyright (C) 2019 Sony Interactive Entertainment Inc.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#include "config.h"
>+#include "ResourceUsageThread.h"
>+
>+#if ENABLE(RESOURCE_USAGE) && OS(WINDOWS)
>+
>+#include <JavaScriptCore/GCActivityCallback.h>
>+#include <JavaScriptCore/VM.h>
>+#include <psapi.h>
>+
>+namespace WebCore {
>+
>+void ResourceUsageThread::platformSaveStateBeforeStarting()
>+{
>+}
>+
>+uint64_t fileTimeToUint64(FILETIME ft)
>+{
>+    ULARGE_INTEGER u;
>+    u.LowPart = ft.dwLowDateTime;
>+    u.HighPart = ft.dwHighDateTime;
>+
>+    return u.QuadPart;
>+}
>+
>+bool getCurrentCpuTime(uint64_t& nowTime, uint64_t& userTime, uint64_t& kernelTime)
>+{
>+    FILETIME creationFileTime, exitFileTime, kernelFileTime, userFileTime;
>+    if (!GetProcessTimes(GetCurrentProcess(), &creationFileTime, &exitFileTime, &kernelFileTime, &userFileTime))
>+        return false;
>+
>+    FILETIME nowFileTime;
>+    GetSystemTimeAsFileTime(&nowFileTime);
>+
>+    nowTime = fileTimeToUint64(nowFileTime);
>+    userTime = fileTimeToUint64(userFileTime);
>+    kernelTime  = fileTimeToUint64(kernelFileTime);
>+
>+    return true;
>+}
>+
>+float cpuUsage()
>+{
>+    static int numberOfProcessors = 0;
>+    static uint64_t lastTime = 0;
>+    static uint64_t lastKernelTime = 0;
>+    static uint64_t lastUserTime = 0;
>+
>+    if (!lastTime) {
>+        SYSTEM_INFO systemInfo;
>+        GetSystemInfo(&systemInfo);
>+        numberOfProcessors = systemInfo.dwNumberOfProcessors;
>+
>+        getCurrentCpuTime(lastTime, lastKernelTime, lastUserTime);
>+        return 0;
>+    }
>+
>+    uint64_t nowTime, kernelTime, userTime;
>+    if (!getCurrentCpuTime(nowTime, kernelTime, userTime))
>+        return 0;
>+
>+    uint64_t elapsed = nowTime - lastTime;
>+    uint64_t totalCPUTime = (kernelTime - lastKernelTime);
>+    totalCPUTime += (userTime - lastUserTime);
>+
>+    lastTime = nowTime;
>+    lastKernelTime = kernelTime;
>+    lastUserTime = userTime;
>+
>+    float usage =  (100.0 * totalCPUTime) / elapsed / numberOfProcessors;
>+    return clampTo<float>(usage, 0, 100);
>+}
>+
>+size_t memoryUsage()
>+{
>+    PROCESS_MEMORY_COUNTERS_EX pmc;
>+    if (GetProcessMemoryInfo(GetCurrentProcess(), (PROCESS_MEMORY_COUNTERS*)&pmc, sizeof(pmc)))
>+        return pmc.PrivateUsage;
>+
>+    return 0;
>+}
>+
>+void ResourceUsageThread::platformCollectCPUData(JSC::VM*, ResourceUsageData& data)
>+{
>+    data.cpu = cpuUsage();
>+
>+    // FIXME: Exclude the ResourceUsage thread.
>+    // FIXME: Exclude the SamplingProfiler thread.
>+    // FIXME: Classify usage per thread.
>+    data.cpuExcludingDebuggerThreads = data.cpu;
>+}
>+
>+void ResourceUsageThread::platformCollectMemoryData(JSC::VM* vm, ResourceUsageData& data)
>+{
>+    data.totalDirtySize = memoryUsage();
>+
>+    size_t currentGCHeapCapacity = vm->heap.blockBytesAllocated();
>+    size_t currentGCOwnedExtra = vm->heap.extraMemorySize();
>+    size_t currentGCOwnedExternal = vm->heap.externalMemorySize();
>+    RELEASE_ASSERT(currentGCOwnedExternal <= currentGCOwnedExtra);
>+
>+    data.categories[MemoryCategory::GCHeap].dirtySize = currentGCHeapCapacity;
>+    data.categories[MemoryCategory::GCOwned].dirtySize = currentGCOwnedExtra - currentGCOwnedExternal;
>+    data.categories[MemoryCategory::GCOwned].externalSize = currentGCOwnedExternal;
>+
>+    data.totalExternalSize = currentGCOwnedExternal;
>+
>+    data.timeOfNextEdenCollection = data.timestamp + vm->heap.edenActivityCallback()->timeUntilFire().valueOr(Seconds(std::numeric_limits<double>::infinity()));
>+    data.timeOfNextFullCollection = data.timestamp + vm->heap.fullActivityCallback()->timeUntilFire().valueOr(Seconds(std::numeric_limits<double>::infinity()));
>+}
>+
>+}
>+
>+#endif
>diff --git a/Source/cmake/OptionsWinCairo.cmake b/Source/cmake/OptionsWinCairo.cmake
>index 17a821661b213c2f2e8659b2120e4342aa0eca19..f6b50bceca02e6703f3f5d7ea6ed4fd49fa520ed 100644
>--- a/Source/cmake/OptionsWinCairo.cmake
>+++ b/Source/cmake/OptionsWinCairo.cmake
>@@ -32,6 +32,7 @@ SET_AND_EXPOSE_TO_BUILD(USE_MEDIA_FOUNDATION ON)
> SET_AND_EXPOSE_TO_BUILD(USE_INSPECTOR_SOCKET_SERVER ${ENABLE_REMOTE_INSPECTOR})
> 
> set(ENABLE_GRAPHICS_CONTEXT_3D ON)
>+set(ENABLE_RESOURCE_USAGE ON)
> set(ENABLE_WEBKIT ON)
> 
> set(USE_ANGLE_EGL ON)
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 9a77b25a2a8128325f8039ede9554622a85ab59b..e452e9a98c420b22828ffaebdedbcfc67ee56c9f 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-02  Takashi Komori  <Takashi.Komori@sony.com>
>+
>+        [WinCairo] Layout tests related to inspector doesn't work.
>+        https://bugs.webkit.org/show_bug.cgi?id=198466
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
>+        (WTR::TestRunner::inspectorTestStubURL):
>+
> 2019-05-30  Andres Gonzalez  <andresg_22@apple.com>
> 
>         Inserting a newline in contenteditable causes two characters to be added instead of one
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp b/Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp
>index 793b59b8250abf9aa5531dc6cb3879f88332258d..6a939d0ebf08884edba39ab87466022bee4d477f 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp
>+++ b/Tools/WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp
>@@ -37,7 +37,25 @@ JSRetainPtr<JSStringRef> TestRunner::pathToLocalResource(JSStringRef)
> 
> JSRetainPtr<JSStringRef> TestRunner::inspectorTestStubURL()
> {
>-    return JSStringCreateWithUTF8CString("");
>+    wchar_t exePath[MAX_PATH];
>+    if (::GetModuleFileName(nullptr, exePath, MAX_PATH)) {
>+        wchar_t drive[_MAX_DRIVE];
>+        wchar_t dir[_MAX_DIR];
>+        _wsplitpath(exePath, drive, dir, nullptr, nullptr);
>+
>+        wchar_t stubPath[MAX_PATH];
>+        wcsncpy(stubPath, L"file:///", MAX_PATH);
>+        wcsncat(stubPath, drive, MAX_PATH - wcslen(stubPath));
>+        wcsncat(stubPath, dir, MAX_PATH - wcslen(stubPath));
>+        wcsncat(stubPath, L"\\WebKit.resources\\WebInspectorUI\\TestStub.html", MAX_PATH - wcslen(stubPath));
>+
>+        char stubPathUTF8[MAX_PATH];
>+        ::WideCharToMultiByte(CP_UTF8, 0, stubPath, -1, stubPathUTF8, MAX_PATH, nullptr, nullptr);
>+
>+        return JSStringCreateWithUTF8CString(stubPathUTF8);
>+    }
>+
>+    return nullptr;
> }
> 
> void TestRunner::platformInitialize()
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 5d98e407cd976f4e693e8aac5ed83148277ddd1f..e17b51ec8cdcba1751f275121011d7aeeac7d75f 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-06-02  Takashi Komori  <Takashi.Komori@sony.com>
>+
>+        [WinCairo] Layout tests related to inspector doesn't work.
>+        https://bugs.webkit.org/show_bug.cgi?id=198466
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/wincairo/TestExpectations:
>+
> 2019-05-30  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Audit: there should be a default test for WebInspectorAudit.Resources functionality
>diff --git a/LayoutTests/platform/wincairo/TestExpectations b/LayoutTests/platform/wincairo/TestExpectations
>index 5f10b53bd72646ab04a05bfb3a457cf1c15bab30..8a9cd8a7a8f2fc1b017cdad7be15bd13860302c6 100644
>--- a/LayoutTests/platform/wincairo/TestExpectations
>+++ b/LayoutTests/platform/wincairo/TestExpectations
>@@ -1564,6 +1564,9 @@ imported/blink [ Skip ]
> imported/mozilla [ Skip ]
> imported/w3c [ Skip ]
> inspector [ Skip ]
>+inspector/memory/ [ Pass ]
>+inspector/cpu-profiler/ [ Pass ]
>+inspector/cpu-profiler/threads.html [ Failure ]
> js/dom/deep-recursion-test.html [ Failure ]
> js/dom/dom-static-property-for-in-iteration.html [ Failure ]
> js/dom/regress-157246.html [ Failure ]
>diff --git a/ChangeLog b/ChangeLog
>index 4fb464521d95111461e7b3a7d1b131a226c7a165..f6023be746dc0ce6b5bb3d5aa894ed3f2a5f002d 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-06-02  Takashi Komori  <Takashi.Komori@sony.com>
>+
>+        [WinCairo] Layout tests related to inspector doesn't work.
>+        https://bugs.webkit.org/show_bug.cgi?id=198466
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Source/cmake/OptionsWinCairo.cmake:
>+
> 2019-05-30  Don Olmstead  <don.olmstead@sony.com>
> 
>         [CMake] Add WEBKIT_FRAMEWORK_TARGET macro

Actions: View | Formatted Diff | Diff

Attachments on bug 198466: 371142 | 371236 | 371237 | 371252 | 371257