WebKit Bugzilla
Attachment 371130 Details for
Bug 198464
: Provide an action to save an image on a link sheet
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198464-20190602092821.patch (text/plain), 2.07 KB, created by
Dean Jackson
on 2019-06-01 16:28:22 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Dean Jackson
Created:
2019-06-01 16:28:22 PDT
Size:
2.07 KB
patch
obsolete
>Subversion Revision: 245943 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 6de9758b3115e606ed4d52fa23c95750d9fa8ad0..3a0182631b784d5dea990a51bbdeb0e23cc6d29b 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,17 @@ >+2019-06-01 Dean Jackson <dino@apple.com> >+ >+ Provide an action to save an image on a link sheet >+ https://bugs.webkit.org/show_bug.cgi?id=198464 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ When providing the set of default actions for a link >+ sheet, if an URL to an image was provided then offer >+ the action to save that image to Photos. >+ >+ * UIProcess/ios/WKActionSheetAssistant.mm: >+ (-[WKActionSheetAssistant defaultActionsForLinkSheet:]): >+ > 2019-05-30 Sihui Liu <sihui_liu@apple.com> > > WKWebsiteDataStore API fails to fetch web storage data for non-persistent data store >diff --git a/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm b/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm >index 82d01af37b0f1ff4dfc63b19f1d28fea67ec4f63..b1d3dd8e36b8a65380fc971f511ff67d1644bd0b 100644 >--- a/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm >+++ b/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm >@@ -542,6 +542,12 @@ ALLOW_DEPRECATED_DECLARATIONS_END > if ([getSSReadingListClass() supportsURL:targetURL]) > [defaultActions addObject:[_WKElementAction _elementActionWithType:_WKElementActionTypeAddToReadingList assistant:self]]; > #endif >+ >+ if ([elementInfo imageURL]) { >+ if (TCCAccessPreflight(getkTCCServicePhotos(), NULL) != kTCCAccessPreflightDenied) >+ [defaultActions addObject:[_WKElementAction _elementActionWithType:_WKElementActionTypeSaveImage assistant:self]]; >+ } >+ > if (![[targetURL scheme] length] || [[targetURL scheme] caseInsensitiveCompare:@"javascript"] != NSOrderedSame) { > [defaultActions addObject:[_WKElementAction _elementActionWithType:_WKElementActionTypeCopy assistant:self]]; > [defaultActions addObject:[_WKElementAction _elementActionWithType:_WKElementActionTypeShare assistant:self]];
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
wenson_hsieh
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198464
: 371130