Attachment 371122 Details for Bug 194929 – Patch

[patch] Patch

bug-194929-20190601130548.patch (text/plain), 5.78 KB, created by Devin Rousso on 2019-06-01 13:05:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-06-01 13:05:48 PDT

Size: 5.78 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 50ea47c82a6a5a0912b6cc19a4fe1a07248b8669..72b020f23d44dd06c4755f40521b45d6e52f5b0f 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,27 @@
>+2019-06-01  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: propagate whether to show prototype information to subobject views
>+        https://bugs.webkit.org/show_bug.cgi?id=194929
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a way to mark the `ObjectTreeView` as holding a JSON value, which extends
>+        `showOnlyProperties` to also hide the prototype of all held values (e.g. children).
>+
>+        * UserInterface/Views/ObjectTreeView.js:
>+        (WI.ObjectTreeView.prototype.showOnlyJSON): Added.
>+        * UserInterface/Views/ObjectTreeView.css:
>+        (.object-tree.properties-only.json-only .object-tree-property .prototype-property): Added.
>+
>+        * UserInterface/Views/AuditTestCaseContentView.js:
>+        (WI.AuditTestCaseContentView.prototype.layout):
>+        * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
>+        (WI.DOMNodeDetailsSidebarPanel.prototype._refreshAssociatedData):
>+        * UserInterface/Views/JSONResourceContentView.css:
>+        (.content-view.resource.json .object-tree .prototype-property): Deleted.
>+        * UserInterface/Views/JSONResourceContentView.js:
>+        (WI.JSONResourceContentView.prototype.contentAvailable):
>+
> 2019-05-31  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: CSS Changes: modifications aren't shared for rules that match multiple elements
>diff --git a/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.js b/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.js
>index 950e364dcaa07c347bd6bd6acbd7a94e59f594f0..48686cdacf11a59fddcdfd79c991eba77350316c 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.js
>@@ -161,7 +161,7 @@ WI.AuditTestCaseContentView = class AuditTestCaseContentView extends WI.AuditTes
> 
>                     let objectTree = element.__objectTree;
>                     if (objectTree) {
>-                        objectTree.showOnlyProperties();
>+                        objectTree.showOnlyJSON();
>                         objectTree.expand();
>                     }
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js
>index 89aec5115d59b283eaff355b098faa66ddfa67dc..1ea6d6df4db1a2c541da864aca47a07c4386564e 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js
>@@ -521,7 +521,7 @@ WI.DOMNodeDetailsSidebarPanel = class DOMNodeDetailsSidebarPanel extends WI.DOMD
> 
>                 let objectTree = element.__objectTree;
>                 if (objectTree) {
>-                    objectTree.showOnlyProperties();
>+                    objectTree.showOnlyJSON();
>                     objectTree.expand();
>                 }
> 
>diff --git a/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.css b/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.css
>index af5bbd8bc062cbde564a2e96e62b063236e01592..1887b1096ee1733aa550bfd088e7252298a3ae87 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.css
>@@ -27,7 +27,3 @@
>     padding: 10px;
>     overflow: scroll;
> }
>-
>-.content-view.resource.json .object-tree .prototype-property {
>-    display: none;
>-}
>diff --git a/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.js b/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.js
>index a78845c5d798063257834835cccc5b20492ca5f3..001ee698a641ef115708515ed8577430d37fd029 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.js
>@@ -69,6 +69,7 @@ WI.JSONResourceContentView = class JSONResourceContentView extends WI.ResourceCo
>             this._remoteObject = WI.RemoteObject.fromPayload(result, this.resource.target);
> 
>             let objectTree = new WI.ObjectTreeView(this._remoteObject);
>+            objectTree.showOnlyJSON();
>             objectTree.expand();
> 
>             this.element.appendChild(objectTree.element);
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css b/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css
>index 7c3fb35b07ed369aec4b8a6be5b0b10361c5f74b..ac0f30357b26505cecd16ada0527656fd2529a4f 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css
>@@ -107,6 +107,10 @@ body[dir=rtl] .object-tree > :matches(.title, .object-preview)::before {
>     opacity: 1;
> }
> 
>+.object-tree.properties-only.json-only .object-tree-property .prototype-property {
>+    display: none;
>+}
>+
> .tree-outline.object li {
>     white-space: nowrap;
>     text-overflow: ellipsis;
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js b/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js
>index 5db1730d2cadd6a29e65c22a9f183557b6942c2d..da2938eb66198628fa35bd9ff4213f2e565157c9 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js
>@@ -222,6 +222,13 @@ WI.ObjectTreeView = class ObjectTreeView extends WI.Object
>         this._includeProtoProperty = false;
>     }
> 
>+    showOnlyJSON()
>+    {
>+        this.showOnlyProperties();
>+
>+        this._element.classList.add("json-only");
>+    }
>+
>     appendTitleSuffix(suffixElement)
>     {
>         if (this._previewView)

Actions: View | Formatted Diff | Diff

Attachments on bug 194929: 371122