Attachment 371098 Details for Bug 198435 – Patch

[patch] Patch

bug-198435-20190531164836.patch (text/plain), 2.65 KB, created by youenn fablet on 2019-05-31 16:48:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-05-31 16:48:37 PDT

Size: 2.65 KB

patch

obsolete

>Subversion Revision: 245849
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index e882850c87de18f7f54a8d86a4e6c0db602718ba..6b97203d0d9729c4a0c65e31168efaaabe885532 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-31  Youenn Fablet  <youenn@apple.com>
>+
>+        Layout test landed flaky in 245873 [ Release ] http/wpt/service-workers/service-worker-networkprocess-crash.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=198435
>+        <rdar://problem/51314295>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make the test more robust by retrying the null test more than once.
>+
>+        * http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt:
>+        * http/wpt/service-workers/service-worker-networkprocess-crash.html:
>+
> 2019-05-31  Youenn Fablet  <youenn@apple.com>
> 
>         Allow resizing of camera video feeds to very small resolutions
>diff --git a/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt b/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt
>index 12dea0fb91b10416d049bc61329def990d3ebea6..2bcfc55dffb8fd1ec420f1628d49c92c2f00f48e 100644
>--- a/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt
>+++ b/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt
>@@ -1,4 +1,5 @@
> 
>+
> PASS Setup worker 
> PASS Frame being controlled 
> PASS Frame being controlled after network process crash 
>diff --git a/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash.html b/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash.html
>index 80420c2ee047810fe5101a201ba76c8f3d5a8b86..9c292bb9c33cbcb9071814c36538b58735dfa3a4 100644
>--- a/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash.html
>+++ b/LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash.html
>@@ -48,9 +48,15 @@ promise_test(async (test) => {
>     if (window.testRunner && window.testRunner.terminateNetworkProcess)
>         testRunner.terminateNetworkProcess();
> 
>-    const frame = await withFrame(scope + "/empty.html");
>-    assert_not_equals(frame.contentWindow.navigator.serviceWorker.controller, null);
>-    frame.remove();
>+    let count = 0;
>+    while (count++ < 20) {
>+        const frame = await withFrame(scope + "/empty.html");
>+        if (frame.contentWindow.navigator.serviceWorker.controller)
>+            break;
>+        frame.remove();
>+        await new Promise(resolve => setTimeout(resolve, 50));
>+    }
>+    assert_true(count < 20);
> }, "Frame being controlled after network process crash");
> </script>
> </body>

Actions: View | Formatted Diff | Diff

Attachments on bug 198435: 371098