Attachment 371089 Details for Bug 198438 – Patch

[patch] Patch

bug-198438-20190531151245.patch (text/plain), 3.06 KB, created by Simon Fraser (smfr) on 2019-05-31 15:12:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2019-05-31 15:12:46 PDT

Size: 3.06 KB

patch

obsolete

>Subversion Revision: 245974
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 5a753625e85eff53ce258342c2fde3c30e8d053d..b2b5dcea486cfacda382348ea6e4ed4206e4c12b 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-31  Simon Fraser  <simon.fraser@apple.com>
>+
>+        tile-coverage-iframe-to-zero-coverage.html flakey after r245974
>+        https://bugs.webkit.org/show_bug.cgi?id=198438
>+
>+        Unreviewed test gardening.
>+        
>+        layerTreeAsText() doesn't force layouts on subframes (webkit.org/b/198439) so
>+        have the test force an update on the subframe via a dummy layerTreeAsText() call.
>+
>+        * tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt:
>+        * tiled-drawing/tile-coverage-iframe-to-zero-coverage.html:
>+
> 2019-05-31  Saam Barati  <sbarati@apple.com>
> 
>         [WHLSL] Make sure we properly emit code for "&*x"
>diff --git a/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt b/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt
>index 252b03040abe6ab24620e26250c5582bde4abdbe..e265eb0b22648edc379d0d89bdc1734faf59a50d 100644
>--- a/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt
>+++ b/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt
>@@ -79,7 +79,7 @@
>                                   (contentsOpaque 1)
>                                   (drawsContent 1)
>                                   (visible rect 0.00, 0.00 0.00 x 0.00)
>-                                  (coverage rect -8.00, -8.00 0.00 x 0.00)
>+                                  (coverage rect 0.00, 0.00 0.00 x 0.00)
>                                   (intersects coverage rect 0)
>                                   (contentsScale 1.00)
>                                   (tile cache coverage 0, 0 0 x 0)
>diff --git a/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage.html b/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage.html
>index 0bbcf89e35bd26be6cdadc29f5ba97d6f82cd926..2b32a6aed9baeaeec0f9024c2aefac95714c2f5f 100644
>--- a/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage.html
>+++ b/LayoutTests/tiled-drawing/tile-coverage-iframe-to-zero-coverage.html
>@@ -24,6 +24,7 @@
>         {
>             setTimeout(function() {
>                 window.scrollTo(0, 3000);
>+				internals.layerTreeAsText(subframe.contentDocument);
>                 if (window.internals) {
>                     document.getElementById('layers').innerText = internals.layerTreeAsText(document,
>                         internals.LAYER_TREE_INCLUDES_VISIBLE_RECTS | internals.LAYER_TREE_INCLUDES_TILE_CACHES);
>@@ -37,7 +38,7 @@
> </head>
> <body>
> 
>-<iframe scrolling="no" srcdoc="<div style='width: 2500px; height: 200px; background-color: silver; will-change: transform'>Stuff here</div>"></iframe>
>+<iframe id="subframe" scrolling="no" srcdoc="<div style='width: 2500px; height: 200px; background-color: silver; will-change: transform'>Stuff here</div>"></iframe>
> <pre id="layers">Layer tree goes here</p>
> </body>
> </html>

Actions: View | Formatted Diff | Diff

Attachments on bug 198438: 371089