Attachment 371078 Details for Bug 198431 – Patch

[patch] Patch

bug-198431-20190531131836.patch (text/plain), 4.22 KB, created by Geoffrey Garen on 2019-05-31 13:18:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Geoffrey Garen

Created: 2019-05-31 13:18:37 PDT

Size: 4.22 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 245972)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-05-31  Geoffrey Garen  <ggaren@apple.com>
>+
>+        Some WeakPtr typedef cleanup
>+        https://bugs.webkit.org/show_bug.cgi?id=198431
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use "using" instead of "typedef", since using is preferred in C++ for
>+        better compatibility with templates.
>+
>+        * Modules/indexeddb/shared/InProcessIDBServer.h:
>+        * html/HTMLMediaElement.h:
>+        * platform/ScrollView.h:
>+
> 2019-05-31  Geoffrey Garen  <ggaren@apple.com>
> 
>         Some WeakPtr cleanup
>Index: Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h
>===================================================================
>--- Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h	(revision 245972)
>+++ Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h	(working copy)
>@@ -54,7 +54,7 @@ class IDBServer;
> class InProcessIDBServer final : public IDBClient::IDBConnectionToServerDelegate, public IDBServer::IDBConnectionToClientDelegate, public RefCounted<InProcessIDBServer>, public IDBServer::IDBBackingStoreTemporaryFileHandler {
> public:
>     using IDBClient::IDBConnectionToServerDelegate::weakPtrFactory;
>-    typedef IDBClient::IDBConnectionToServerDelegate::WeakValueType WeakValueType;
>+    using WeakValueType = IDBClient::IDBConnectionToServerDelegate::WeakValueType;
> 
>     WEBCORE_EXPORT static Ref<InProcessIDBServer> create(PAL::SessionID);
>     WEBCORE_EXPORT static Ref<InProcessIDBServer> create(PAL::SessionID, const String& databaseDirectoryPath);
>Index: Source/WebCore/html/HTMLMediaElement.h
>===================================================================
>--- Source/WebCore/html/HTMLMediaElement.h	(revision 245972)
>+++ Source/WebCore/html/HTMLMediaElement.h	(working copy)
>@@ -149,7 +149,7 @@ class HTMLMediaElement
> {
>     WTF_MAKE_ISO_ALLOCATED(HTMLMediaElement);
> public:
>-    typedef HTMLElement::WeakValueType WeakValueType;
>+    using WeakValueType = HTMLElement::WeakValueType;
>     using HTMLElement::weakPtrFactory;
> 
>     RefPtr<MediaPlayer> player() const { return m_player; }
>Index: Source/WebCore/platform/ScrollView.h
>===================================================================
>--- Source/WebCore/platform/ScrollView.h	(revision 245972)
>+++ Source/WebCore/platform/ScrollView.h	(working copy)
>@@ -65,7 +65,7 @@ class ScrollView : public Widget, public
> public:
>     virtual ~ScrollView();
> 
>-    typedef Widget::WeakValueType WeakValueType;
>+    using WeakValueType = Widget::WeakValueType;
>     using Widget::weakPtrFactory;
> 
>     // ScrollableArea functions.
>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 245979)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-05-31  Geoffrey Garen  <ggaren@apple.com>
>+
>+        Some WeakPtr typedef cleanup
>+        https://bugs.webkit.org/show_bug.cgi?id=198431
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use "using" instead of "typedef", since using is preferred in C++ for
>+        better compatibility with templates.
>+
>+        * UIProcess/WebAuthentication/AuthenticatorManager.h:
>+
> 2019-05-31  Tim Horton  <timothy_horton@apple.com>
> 
>         Optionally respect device management restrictions when loading from the network
>Index: Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h
>===================================================================
>--- Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h	(revision 245972)
>+++ Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h	(working copy)
>@@ -49,7 +49,7 @@ public:
>     using TransportSet = HashSet<WebCore::AuthenticatorTransport, WTF::IntHash<WebCore::AuthenticatorTransport>, WTF::StrongEnumHashTraits<WebCore::AuthenticatorTransport>>;
> 
>     using AuthenticatorTransportService::Observer::weakPtrFactory;
>-    typedef AuthenticatorTransportService::Observer::WeakValueType WeakValueType;
>+    using WeakValueType = AuthenticatorTransportService::Observer::WeakValueType;
> 
>     AuthenticatorManager();
>     virtual ~AuthenticatorManager() = default;

Actions: View | Formatted Diff | Diff

Attachments on bug 198431: 371078