Attachment 370983 Details for Bug 198389 – Patch

[patch] Patch

bug-198389-20190530151027.patch (text/plain), 2.17 KB, created by Wenson Hsieh on 2019-05-30 15:10:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-05-30 15:10:28 PDT

Size: 2.17 KB

patch

obsolete

>Subversion Revision: 245902
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 1c612b97f065452cc129aa7b4419a73f2b38c2a1..3039459cece840218f1317dc00685d66836641bf 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-05-30  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        DragAndDropTests.DataTransferExposePlainTextWithFileURLAsFile API test is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=198389
>+        <rdar://problem/51266096>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This test started failing, since the fallback name for a dropped text file changed from "text.txt" to
>+        "Document.txt" on newer iOS SDK versions. We simply fix this test by checking that the name of the file ends
>+        with ".txt", and that the MIME type of the file is "text/plain".
>+
>+        * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
>+        (TestWebKitAPI::TEST):
>+
> 2019-05-30  David Quesada  <david_quesada@apple.com>
> 
>         REGRESSION (r245756) [Mac] 2 TestWebKitAPI.DownloadProgress* and TestWebKitAPI._WKDownload.DownloadMonitorCancel are flaky timeouts
>diff --git a/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm b/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm
>index 16cbe23f0738bbcd3b87dc819519fb70e6de6e74..f110b24b84b5f8eed2e050a0ae66a4b296e7efc2 100644
>--- a/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm
>+++ b/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm
>@@ -1921,7 +1921,10 @@ TEST(DragAndDropTests, DataTransferExposePlainTextWithFileURLAsFile)
>     EXPECT_WK_STREQ("", [webView stringByEvaluatingJavaScript:@"urlData.textContent"]);
>     EXPECT_WK_STREQ("", [webView stringByEvaluatingJavaScript:@"htmlData.textContent"]);
>     EXPECT_WK_STREQ("(FILE, text/plain)", [webView stringByEvaluatingJavaScript:@"items.textContent"]);
>-    EXPECT_WK_STREQ("('text.txt', text/plain)", [webView stringByEvaluatingJavaScript:@"files.textContent"]);
>+
>+    NSString *filesOutput = [webView stringByEvaluatingJavaScript:@"files.textContent"];
>+    EXPECT_TRUE([filesOutput containsString:@"text/plain)"]);
>+    EXPECT_TRUE([filesOutput containsString:@".txt', "]);
> }
> 
> TEST(DragAndDropTests, DataTransferGetDataCannotReadPrivateArbitraryTypes)

Actions: View | Formatted Diff | Diff

Attachments on bug 198389: 370983