Attachment 370947 Details for Bug 198195 – Patch

[patch] Patch

bug-198195-20190530093331.patch (text/plain), 3.38 KB, created by Jonathan Bedard on 2019-05-30 09:33:32 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-05-30 09:33:32 PDT

Size: 3.38 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 245886)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2019-05-30  Jonathan Bedard  <jbedard@apple.com>
>+
>+        REGRESSION (r244353) [Mac WK2] Layout Test fast/css/sticky/sticky-left-percentage.html is a flaky ImageOnlyFailure (198195)
>+        https://bugs.webkit.org/show_bug.cgi?id=198195
>+        <rdar://problem/51081794>
>+        Need the bug URL (OOPS!).
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Handle race condition between resize and snapshot. Even though everything in WebKit thinks the windows is the new size,
>+        CGWindowListCreateImage might still be using the old size.
>+
>+        * fast/css/sticky/sticky-left-percentage-expected.html:
>+        * fast/css/sticky/sticky-left-percentage.html:
>+        * platform/mac-wk2/TestExpectations:
>+
> 2019-05-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
> 
>         REGRESSION (r244182) [Mac WK2] Layout Test imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
>Index: LayoutTests/fast/css/sticky/sticky-left-percentage-expected.html
>===================================================================
>--- LayoutTests/fast/css/sticky/sticky-left-percentage-expected.html	(revision 245863)
>+++ LayoutTests/fast/css/sticky/sticky-left-percentage-expected.html	(working copy)
>@@ -37,7 +37,18 @@
>     }
> </style>
> <script>
>-    window.resizeTo(800, 700)
>+    if (window.testRunner)
>+        testRunner.waitUntilDone();
>+
>+    window.onresize = function() {
>+        setTimeout(function(){
>+            if (window.testRunner)
>+                testRunner.notifyDone();
>+        }, 50);
>+    }
>+    window.addEventListener('load', function() {
>+        window.resizeTo(800, 700);
>+    }, false);
> </script>
> </head>
> <body>
>Index: LayoutTests/fast/css/sticky/sticky-left-percentage.html
>===================================================================
>--- LayoutTests/fast/css/sticky/sticky-left-percentage.html	(revision 245863)
>+++ LayoutTests/fast/css/sticky/sticky-left-percentage.html	(working copy)
>@@ -41,12 +41,19 @@
>     }
> </style>
> <script>
>-    function doTest()
>-    {
>-        window.scrollTo(100, 0);
>-        window.resizeTo(800, 700)
>+    if (window.testRunner)
>+        testRunner.waitUntilDone();
>+
>+    window.onresize = function() {
>+        setTimeout(function(){
>+            if (window.testRunner)
>+                testRunner.notifyDone();
>+        }, 50);
>     }
>-    window.addEventListener('load', doTest, false);
>+    window.addEventListener('load', function() {
>+        window.scrollTo(100, 0);
>+        window.resizeTo(800, 700);
>+    }, false);
> </script>
> </head>
> <body>
>Index: LayoutTests/platform/mac-wk2/TestExpectations
>===================================================================
>--- LayoutTests/platform/mac-wk2/TestExpectations	(revision 245863)
>+++ LayoutTests/platform/mac-wk2/TestExpectations	(working copy)
>@@ -954,6 +954,4 @@ webkit.org/b/189672 [ Mojave Debug ] web
> 
> webkit.org/b/196445 [ Debug ] storage/indexeddb/modern/deletedatabase-2-private.html [ Pass Failure ]
> 
>-webkit.org/b/198195 [ Release ] fast/css/sticky/sticky-left-percentage.html [ Pass ImageOnlyFailure ]
>-
> webkit.org/b/187828 [ Release ] fast/css-grid-layout/flex-content-sized-columns-resize.html [ Pass ImageOnlyFailure ]
>\ No newline at end of file

Flags:

ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 198195: 370947 | 370953 | 370956 | 370958 | 370974