WebKit Bugzilla
Attachment 370921 Details for
Bug 198281
: [WinCairo][MediaFoundation] Crashing while releasing IMFTopology in ~MediaPlayerPrivateMediaFoundation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
WIP patch
wip.diff (text/plain), 1.74 KB, created by
Fujii Hironori
on 2019-05-29 22:20:24 PDT
(
hide
)
Description:
WIP patch
Filename:
MIME Type:
Creator:
Fujii Hironori
Created:
2019-05-29 22:20:24 PDT
Size:
1.74 KB
patch
obsolete
>diff --git a/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp b/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp >index 00b0d0884fc..c4dae17e26e 100644 >--- a/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp >+++ b/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp >@@ -441,13 +441,13 @@ bool MediaPlayerPrivateMediaFoundation::endSession() > m_mediaSession->Shutdown(); > m_mediaSession = nullptr; > } >- >+#if 0 > if (!MFShutdownPtr()) > return false; > > HRESULT hr = MFShutdownPtr()(); > ASSERT_UNUSED(hr, SUCCEEDED(hr)); >- >+#endif > return true; > } > >@@ -693,7 +693,7 @@ void MediaPlayerPrivateMediaFoundation::createVideoWindow() > return; > hWndParent = view->hostWindow()->platformPageClient(); > >- m_hwndVideo = CreateWindowEx(WS_EX_NOACTIVATE | WS_EX_TRANSPARENT, registerVideoWindowClass(), 0, WS_CHILD | WS_CLIPSIBLINGS | WS_CLIPCHILDREN, >+ m_hwndVideo = CreateWindowEx(WS_EX_NOACTIVATE | WS_EX_TRANSPARENT, registerVideoWindowClass(), 0, WS_POPUP | WS_CLIPSIBLINGS | WS_CLIPCHILDREN, > 0, 0, 0, 0, hWndParent, 0, 0, 0); > } > >diff --git a/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp b/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp >index 353c2b1e5ac..32916143f43 100644 >--- a/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp >+++ b/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp >@@ -129,6 +129,8 @@ WebKitBrowserWindow::WebKitBrowserWindow(WKPageConfigurationRef conf, HWND mainW > { > RECT rect = { }; > m_view = adoptWK(WKViewCreate(rect, conf, mainWnd)); >+ WKViewSetIsInWindow(m_view.get(), true); >+ > auto page = WKViewGetPage(m_view.get()); > > WKPageNavigationClientV0 navigationClient = { };
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198281
:
370710
|
370919
|
370921
|
375527