Attachment 370885 Details for Bug 198351 – Patch v1

[patch] Patch v1

bug-198351-20190529143812.patch (text/plain), 2.42 KB, created by David Kilzer (:ddkilzer) on 2019-05-29 14:38:14 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2019-05-29 14:38:14 PDT

Size: 2.42 KB

patch

obsolete

>Subversion Revision: 245854
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index a449a9ba21be67bd2e6ed03d328ac4761d79c2ca..61aed8f3cac18e10e00eae35da1cd5e3eb2fbb87 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-05-29  David Kilzer  <ddkilzer@apple.com>
>+
>+        Clean up a few #include statements in WTF
>+        <https://webkit.org/b/198351>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * benchmarks/HashSetDFGReplay.cpp:
>+        - Add missing "config.h" include.
>+        * wtf/ParallelJobsGeneric.cpp:
>+        - Replace include of ParallelJobs.h with
>+          ParallelJobsGeneric.h.
>+        * wtf/StackBounds.cpp:
>+        - Fix include ordering of StackBounds.h.
>+
> 2019-05-29  David Kilzer  <ddkilzer@apple.com>
> 
>         IndexedDatabase Server thread in com.apple.WebKit.Networking process leaks objects into an autoreleasePool that's never cleared
>diff --git a/Source/WTF/benchmarks/HashSetDFGReplay.cpp b/Source/WTF/benchmarks/HashSetDFGReplay.cpp
>index 1b03d1d62f3271434f8ea76bd5da5f49f8b5f19a..b66d5825bc44dc33b1524c7f33e45f0b109b6bd9 100644
>--- a/Source/WTF/benchmarks/HashSetDFGReplay.cpp
>+++ b/Source/WTF/benchmarks/HashSetDFGReplay.cpp
>@@ -25,6 +25,8 @@
> 
> // Compile with: xcrun clang++ -o HashSetDFGReplay Source/WTF/benchmarks/HashSetDFGReplay.cpp -O2 -W -ISource/WTF -ISource/WTF/benchmarks -LWebKitBuild/Release -lWTF -framework Foundation -licucore -std=c++11 -fvisibility=hidden -DNDEBUG=1
> 
>+#include "config.h"
>+
> #include <wtf/DataLog.h>
> #include <wtf/HashSet.h>
> #include <wtf/WallTime.h>
>diff --git a/Source/WTF/wtf/ParallelJobsGeneric.cpp b/Source/WTF/wtf/ParallelJobsGeneric.cpp
>index 8acdc57ea8c254e5764921798208bcfc7bbc1c37..cd53a9abd8cd02d18b05494c6f79db3b4c1ddac4 100644
>--- a/Source/WTF/wtf/ParallelJobsGeneric.cpp
>+++ b/Source/WTF/wtf/ParallelJobsGeneric.cpp
>@@ -26,11 +26,11 @@
>  */
> 
> #include "config.h"
>+#include <wtf/ParallelJobsGeneric.h>
> 
> #if ENABLE(THREADING_GENERIC)
> 
> #include <wtf/NumberOfCores.h>
>-#include <wtf/ParallelJobs.h>
> 
> namespace WTF {
> 
>diff --git a/Source/WTF/wtf/StackBounds.cpp b/Source/WTF/wtf/StackBounds.cpp
>index 83e0154b980fa5eb171c810826525934f0b1e967..aab20fa76dc22aee36f4ab1bb9a7d2a0cbd75a97 100644
>--- a/Source/WTF/wtf/StackBounds.cpp
>+++ b/Source/WTF/wtf/StackBounds.cpp
>@@ -19,9 +19,10 @@
>  */
> 
> #include "config.h"
>+#include <wtf/StackBounds.h>
>+
> #include <mutex>
> #include <wtf/NoTailCalls.h>
>-#include <wtf/StackBounds.h>
> 
> #if OS(DARWIN)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198351: 370885