Attachment 370826 Details for Bug 198244 – WIP4

[patch] WIP4

gmail-scroll-inset-fix.patch (text/plain), 1.26 KB, created by Ryosuke Niwa on 2019-05-28 20:14:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2019-05-28 20:14:04 PDT

Size: 1.26 KB

patch

obsolete

>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>index f6a7865db73..cf7a48be50f 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>@@ -1988,7 +1988,9 @@ - (void)_didCommitLayerTree:(const WebKit::RemoteLayerTreeTransaction&)layerTree
>     [_scrollView setMaximumZoomScale:layerTreeTransaction.maximumScaleFactor()];
>     [_scrollView setZoomEnabled:layerTreeTransaction.allowsUserScaling()];
> #if ENABLE(ASYNC_SCROLLING)
>-    [_scrollView setScrollEnabled:_page->scrollingCoordinatorProxy()->hasScrollableMainFrame()];
>+    UIEdgeInsets insets = [[self scrollView] adjustedContentInset];
>+    bool hasContentInset = insets.left || insets.right || insets.top || insets.bottom;
>+    [_scrollView setScrollEnabled:_page->scrollingCoordinatorProxy()->hasScrollableMainFrame() || hasContentInset];
> #endif
>     if (!layerTreeTransaction.scaleWasSetByUIProcess() && ![_scrollView isZooming] && ![_scrollView isZoomBouncing] && ![_scrollView _isAnimatingZoom] && [_scrollView zoomScale] != layerTreeTransaction.pageScaleFactor()) {
>         LOG_WITH_STREAM(VisibleRects, stream << " updating scroll view with pageScaleFactor " << layerTreeTransaction.pageScaleFactor());

Actions: View | Formatted Diff | Diff

Attachments on bug 198244: 370624 | 370625 | 370628 | 370629 | 370631 | 370632 | 370825 | 370826 | 371000 | 371024 | 371032