Attachment 370811 Details for Bug 198308 – Patch

[patch] Patch

bug-198308-20190528172647.patch (text/plain), 2.09 KB, created by Brent Fulgham on 2019-05-28 17:26:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2019-05-28 17:26:48 PDT

Size: 2.09 KB

patch

obsolete

>Subversion Revision: 245817
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 63c5021cb455fdaff1e0b57c02b44472df4e1f3b..45c7f3e4271b197459d14f9a5102475fe3abe3dd 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-05-28  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Correct flaky WebAuthN test cases
>+        https://bugs.webkit.org/show_bug.cgi?id=198308
>+        <rdar://problem/48677219>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Correct offset math in the MockHidConnection implementation. The write position of
>+        the payload buffer was computed using the value of 'size()', which is set to the full
>+        capacity of the vector after a 'grow()' operation.
>+
>+        Tests: http/wpt/webauthn
>+
>+        * UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
>+        (WebKit::MockHidConnection::feedReports): 
>+
> 2019-05-28  Brent Fulgham  <bfulgham@apple.com>
> 
>         Update sandbox rules for more News use cases
>diff --git a/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp b/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
>index 39dd75288a957640d9583ab018f21ef933997022..c8ba9183e9c8a253ee31524d1e2ba99171a529eb 100644
>--- a/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
>+++ b/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidConnection.cpp
>@@ -195,10 +195,11 @@ void MockHidConnection::feedReports()
>         Vector<uint8_t> payload;
>         payload.reserveInitialCapacity(kHidInitResponseSize);
>         payload.appendVector(m_nonce);
>+        size_t writePosition = payload.size();
>         if (stagesMatch() && m_configuration.hid->error == Mock::Error::WrongNonce)
>             payload[0]--;
>         payload.grow(kHidInitResponseSize);
>-        cryptographicallyRandomValues(payload.data() + payload.size(), CtapChannelIdSize);
>+        cryptographicallyRandomValues(payload.data() + writePosition, CtapChannelIdSize);
>         auto channel = kHidBroadcastChannel;
>         if (stagesMatch() && m_configuration.hid->error == Mock::Error::WrongChannelId)
>             channel--;

Actions: View | Formatted Diff | Diff

Attachments on bug 198308: 370811