Attachment 370808 Details for Bug 198314 – Patch

[patch] Patch

bug-198314-20190528171534.patch (text/plain), 1.31 KB, created by Yusuke Suzuki on 2019-05-28 17:15:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2019-05-28 17:15:34 PDT

Size: 1.31 KB

patch

obsolete

>Subversion Revision: 245828
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 568e55de667d0d7e0577df90a2d0ac64ef448c4d..5e46e62bb43c2a7c55577a9067babc7474555bd5 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-28  Yusuke Suzuki  <ysuzuki@apple.com>
>+
>+        GCHeapInspector should accept weird filename
>+        https://bugs.webkit.org/show_bug.cgi?id=198314
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        GCHeapInspector filenameForPath should have a fallback path if regexp does not match against the given path.
>+
>+        * GCHeapInspector/script/interface.js:
>+        (filenameForPath):
>+
> 2019-05-28  Eric Carlson  <eric.carlson@apple.com>
> 
>         [MacOS] Filter GVA warning logged to stdout
>diff --git a/Tools/GCHeapInspector/script/interface.js b/Tools/GCHeapInspector/script/interface.js
>index 8ab0fff8d49d7e889b28d4411c6273b897e1efd9..ee8f4ca6e03b0e1e7eddcc05294cecb588e81169 100644
>--- a/Tools/GCHeapInspector/script/interface.js
>+++ b/Tools/GCHeapInspector/script/interface.js
>@@ -446,7 +446,10 @@ function loadResults(dataString, filename)
> 
> function filenameForPath(filepath)
> {
>-    return filepath.match(/([^\/]+)(?=\.\w+$)/)[0];
>+    var matched = filepath.match(/([^\/]+)(?=\.\w+$)/);
>+    if (matched)
>+        return matched[0];
>+    return filepath;
> }
> 
> function hideDescription()

Actions: View | Formatted Diff | Diff

Attachments on bug 198314: 370808