Attachment 370801 Details for Bug 198310 – ROLLOUT of r245795

[patch] ROLLOUT of r245795

bug-198310-20190528162152.patch (text/plain), 1.83 KB, created by WebKit Commit Bot on 2019-05-28 16:21:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2019-05-28 16:21:53 PDT

Size: 1.83 KB

patch

obsolete

>Subversion Revision: 245829
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index ef33bfe1ab49f48282d392aceaf614c5cdc9e31c..35fa55bf6fdd3e5ac99903ec8a4b032d6f899a43 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-05-28  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r245795.
>+        https://bugs.webkit.org/show_bug.cgi?id=198310
>+
>+        causing internal testers to exit early after 50 crashes.
>+        (Requested by ShawnRoberts on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[Pointer Events] Test at pointerevents/ios/touch-action-none-
>+        in-overflow-scrolling-touch.html times out"
>+        https://bugs.webkit.org/show_bug.cgi?id=198275
>+        https://trac.webkit.org/changeset/245795
>+
> 2019-05-28  Brent Fulgham  <bfulgham@apple.com>
> 
>         Remove dead code from sandboxes
>diff --git a/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm b/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm
>index 1a99e9fa4af0da0ef211a76a59511e569cbd7390..a6cc40346f6e9df12bdc7d1f75b2449d5beda20f 100644
>--- a/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm
>+++ b/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm
>@@ -98,16 +98,7 @@ OptionSet<WebCore::TouchAction> touchActionsForPoint(UIView *rootView, const Web
>     if (viewsAtPoint.isEmpty())
>         return { WebCore::TouchAction::Auto };
> 
>-    UIView *hitView;
>-    for (auto *view : WTF::makeReversedRange(viewsAtPoint)) {
>-        if ([view isKindOfClass:[WKCompositingView class]]) {
>-            hitView = view;
>-            break;
>-        }
>-    }
>-
>-    if (!hitView)
>-        return { WebCore::TouchAction::Auto };
>+    auto *hitView = viewsAtPoint.last();
> 
>     CGPoint hitViewPoint = [hitView convertPoint:point fromView:rootView];
>

Flags:

thorton: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 198310: 370801