Attachment 370777 Details for Bug 198303 – Proposed Patch

[patch] Proposed Patch

filter-gva-warnings-patch.txt (text/plain), 1.77 KB, created by Eric Carlson on 2019-05-28 13:21:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Carlson

Created: 2019-05-28 13:21:44 PDT

Size: 1.77 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index dbef1cc36c1..a3a1a6a3307 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-05-28  Eric Carlson  <eric.carlson@apple.com>
>+
>+        [MacOS] Filter GVA warning logged to stdout
>+        https://bugs.webkit.org/show_bug.cgi?id=198303
>+        <rdar://problem/50098041>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/port/mac.py:
>+        (MacPort.logging_patterns_to_strip): Filter GVA warnings.
>+
> 2019-05-20  Keith Rollin  <krollin@apple.com>
> 
>         generate-xcfilelists is stranding temporary files
>diff --git a/Tools/Scripts/webkitpy/port/mac.py b/Tools/Scripts/webkitpy/port/mac.py
>index 2145d021613..726222e8de3 100644
>--- a/Tools/Scripts/webkitpy/port/mac.py
>+++ b/Tools/Scripts/webkitpy/port/mac.py
>@@ -266,8 +266,18 @@ class MacPort(DarwinPort):
>             self._helper = None
> 
>     def logging_patterns_to_strip(self):
>-        # FIXME: Remove this after <rdar://problem/15605007> and <rdar://problem/35954459> are fixed.
>-        return [(re.compile('(AVF|GVA) info:.*\n'), ''), ('AVDCreateGPUAccelerator: Error loading GPU renderer\n', '')]
>+        logging_patterns = []
>+
>+        # FIXME: Remove this after <rdar://problem/15605007> is fixed.
>+        logging_patterns.append((re.compile('(AVF|GVA) info:.*\n'), ''))
>+
>+        # FIXME: Remove this after <rdar://problem/35954459> is fixed.
>+        logging_patterns.append(('AVDCreateGPUAccelerator: Error loading GPU renderer\n', ''))
>+
>+        # FIXME: Remove this after <rdar://problem/51191120> is fixed.
>+        logging_patterns.append((re.compile('GVA warning: getFreeDRMInstanceCount, maxDRMInstanceCount: .*\n'), ''))
>+
>+        return logging_patterns
> 
>     def stderr_patterns_to_strip(self):
>         worthless_patterns = []

Actions: View | Formatted Diff | Diff

Attachments on bug 198303: 370777