Attachment 370749 Details for Bug 197008 – Patch

[patch] Patch

bug-197008-20190528181413.patch (text/plain), 7.18 KB, created by Antoine Quint on 2019-05-28 09:14:15 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antoine Quint

Created: 2019-05-28 09:14:15 PDT

Size: 7.18 KB

patch

obsolete

>Subversion Revision: 245809
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index f25cbbca484b80edf9224ee4cfc0c14ed82c49dd..e5670229f6c9b24526819d822b3e3f50560b1215 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-28  Antoine Quint  <graouts@apple.com>
>+
>+        [Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
>+        https://bugs.webkit.org/show_bug.cgi?id=197008
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see https://github.com/w3c/pointerevents/issues/284
>+        and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
>+        the TestExpectations.
>+
>+        * platform/mac/TestExpectations:
>+
> 2019-05-27  Takashi Komori  <Takashi.Komori@sony.com>
> 
>         [CURL] Fix crashing SocketStreamHandle.
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 4adb4512b262cbcc83cffa6f33896d53c1b441ee..20ad323159d31e8cfddf3bd8e180650b3da20a13 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-05-28  Antoine Quint  <graouts@apple.com>
>+
>+        [Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
>+        https://bugs.webkit.org/show_bug.cgi?id=197008
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see https://github.com/w3c/pointerevents/issues/284
>+        and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
>+        the TestExpectations.
>+
>+        * web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt:
>+        * web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html:
>+
> 2019-05-27  Oriol Brufau  <obrufau@igalia.com>
> 
>         [css-grid] Preserve repeat() notation when serializing declared values
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt
>index cd2a77595f4bfa3129eaad9f7162edc3e4145925..14e01be9336444ae3b96b319d4b160029377e414 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt
>@@ -10,21 +10,11 @@ Target1
> Done
> The following pointer types were detected: mouse.
> 
>-The following events were logged: mouseup@target0, mousedown@target1, mousemove@target1, mouseup@target1.
>+The following events were logged: mousedown@target1, mousemove@target1, mouseup@target1.
> 
> 
>-Harness Error (FAIL), message = 1 duplicate test name: "mouseup's time stamp should be the same as pointerup's time stamp."
>-
> PASS Suppress compat mouse events on drag 
> PASS primary pointer pointerdown@target0 
>-PASS mouseup's time stamp should be the same as pointerup's time stamp. 
>-PASS Pointer Event: Suppress compatibility mouse events on drag 
> PASS primary pointer pointerdown@target1 
>-PASS mousedown's time stamp should be the same as pointerdown's time stamp. 
>-PASS Pointer Event: Suppress compatibility mouse events on drag 1 
>-PASS mousemove's time stamp should be the same as pointermove's time stamp. 
>-FAIL Pointer Event: Suppress compatibility mouse events on drag 2 assert_equals: The time stamp of the compat mouse event should be the same as its pointerevent expected 100 but got 99
>-PASS mouseup's time stamp should be the same as pointerup's time stamp. 
>-PASS Pointer Event: Suppress compatibility mouse events on drag 3 
>-FAIL Event log assert_equals: expected "mousedown@target1, mousemove@target1, mouseup@target1" but got "mouseup@target0, mousedown@target1, mousemove@target1, mouseup@target1"
>+PASS Event log 
> 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html b/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
>index 5bab6e66121cebc47213914fb07f7995d8b0722d..6ed75ab4cbcda3c673b3328a826019bdade4db5d 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
>@@ -46,7 +46,6 @@
>           var target_list = ["target0", "target1"];
>           var pointer_event_list = ["pointerdown" , "pointermove", "pointerup"];
>           var mouse_event_list = ["mousedown", "mouseup", "mousemove"];
>-          var last_pointer_event = null;
> 
>           target_list.forEach(function(targetId) {
>               var target = document.getElementById(targetId);
>@@ -64,8 +63,6 @@
> 
>                       if (label === "pointerdown@target0")
>                           event.preventDefault();
>-
>-                      last_pointer_event = event;
>                   });
>               });
> 
>@@ -77,11 +74,6 @@
>                       event_log.push(event.type + "@" + targetId);
> 
>                       include_next_mousemove = (event.type == "mousedown");
>-                      test(function() {
>-                          test(function () {
>-                              assert_equals(event.timeStamp, last_pointer_event.timeStamp, "The time stamp of the compat mouse event should be the same as its pointerevent");
>-                          });
>-                      }, event.type + "'s time stamp should be the same as " + last_pointer_event.type + "'s time stamp.");
>                   });
>               });
>           });
>diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
>index 719f102f0b8d0bde9cc3c807cd9c905bb2f10e68..cb6383bad4ef7b62e826fbd73c5b2adbf9e88fef 100644
>--- a/LayoutTests/platform/mac/TestExpectations
>+++ b/LayoutTests/platform/mac/TestExpectations
>@@ -1880,7 +1880,6 @@ imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointermo
> imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-manual.html [ Skip ]
> 
> webkit.org/b/197005 imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_is_first.html [ Skip ]
>-webkit.org/b/197008 imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html [ Pass Failure ]
> webkit.org/b/197007 imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_coordinates_when_locked.html [ Skip ]
> webkit.org/b/197009 imported/w3c/web-platform-tests/pointerevents/pointerevent_setpointercapture_invalid_pointerid.html [ Failure Pass ]
> webkit.org/b/197058 imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_in_frame.html [ Failure Pass ]

Actions: View | Formatted Diff | Diff

Attachments on bug 197008: 370749