Attachment 370706 Details for Bug 196875 – Patch

[patch] Patch

bug-196875-20190527134919.patch (text/plain), 3.23 KB, created by Devin Rousso on 2019-05-27 13:49:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-05-27 13:49:20 PDT

Size: 3.23 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index b2d158a875b503821e4b6b198dce1eb813ec8fb9..fd5e59c20356277003ee14cc34506e9ef7f16b39 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,26 @@
>+2019-05-27  Devin Rousso  <drousso@apple.com>
>+
>+        REGRESSION (r244182): inspector/canvas/recording-webgl-snapshots.html became flaky on WK1
>+        https://bugs.webkit.org/show_bug.cgi?id=196875
>+        <rdar://problem/49873252>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove the `frameLimit` configuration on these tests, as they're short enough that when
>+        running in debug, the timing between the `InspectorCanvasAgent` automatically stopping the
>+        recording and the test page's `LastFrame` event (which will manually stop the recording) is
>+        too close and can result in a race condition.
>+
>+        Instead, just wait for the test page to say "done" (`LastFrame`) before stopping the
>+        recording, ensuring that the full "flow" of the recording is under the control of the test.
>+
>+        This isn't an issue when using Web Inspector "normally" (e.g. not in a test), because the
>+        frontend UI will "ignore" these types of errors, not to mention it would be much harder for
>+        a person to get the timing just right to even encounter this situation.
>+
>+        * inspector/canvas/recording-webgl-snapshots.html:
>+        * inspector/canvas/recording-webgl2-snapshots.html:
>+
> 2019-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Touch support is reported even when the device doesn't have a touch screen
>diff --git a/LayoutTests/inspector/canvas/recording-webgl-snapshots.html b/LayoutTests/inspector/canvas/recording-webgl-snapshots.html
>index b70c7c59ee6a0b03f5ac19ef8c01b1f6568016b9..3b5f33e6d12c63eeea6b17b2d5cf82e50a708a8a 100644
>--- a/LayoutTests/inspector/canvas/recording-webgl-snapshots.html
>+++ b/LayoutTests/inspector/canvas/recording-webgl-snapshots.html
>@@ -100,7 +100,7 @@ function test() {
>         name: "Canvas.recordingWebGL.snapshots",
>         description: "Check that the snapshot taken after each visual action is different.",
>         test(resolve, reject) {
>-            startRecording(WI.Canvas.ContextType.WebGL, resolve, reject, {frameCount: 1, checkForContentChange: true});
>+            startRecording(WI.Canvas.ContextType.WebGL, resolve, reject, {checkForContentChange: true});
>         },
>         timeout: -1,
>     });
>diff --git a/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html b/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html
>index 82f27c9d64f7da328655921ee30888939f6cb59e..0190520660fe0be2e10990cd9f9974e702378224 100644
>--- a/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html
>+++ b/LayoutTests/inspector/canvas/recording-webgl2-snapshots.html
>@@ -102,7 +102,7 @@ function test() {
>         name: "Canvas.recordingWebGL2.snapshots",
>         description: "Check that the snapshot taken after each visual action is different.",
>         test(resolve, reject) {
>-            startRecording(WI.Canvas.ContextType.WebGL2, resolve, reject, {frameCount: 1, checkForContentChange: true});
>+            startRecording(WI.Canvas.ContextType.WebGL2, resolve, reject, {checkForContentChange: true});
>         },
>         timeout: -1,
>     });

Actions: View | Formatted Diff | Diff

Attachments on bug 196875: 370706 | 370754 | 370771