WebKit Bugzilla
Attachment 370692 Details for
Bug 198275
: [Pointer Events] Test at pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html times out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198275-20190527173435.patch (text/plain), 2.04 KB, created by
Antoine Quint
on 2019-05-27 08:34:36 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Antoine Quint
Created:
2019-05-27 08:34:36 PDT
Size:
2.04 KB
patch
obsolete
>Subversion Revision: 245774 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 800bddcef13920e4ba73fff38bd7e6477c3ec15d..8ced7242062b5850f7263763631c900cac9d729b 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,17 @@ >+2019-05-27 Antoine Quint <graouts@apple.com> >+ >+ [Pointer Events] Test at pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html times out >+ https://bugs.webkit.org/show_bug.cgi?id=198275 >+ <rdar://problem/50618496> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Only WKCompositingView instances may have associated touch-action data, so we should filter out any hit-testing view >+ that isn't a WKCompositingView when finding the view that should hit-test when looking for touch-action information. >+ >+ * UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: >+ (WebKit::touchActionsForPoint): >+ > 2019-05-24 Youenn Fablet <youenn@apple.com> > > REGRESSION (r245715?) [WK2] Layout Test http/wpt/cache-storage/cache-storage-networkprocess-crash.html is a flaky failure >diff --git a/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm b/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm >index a6cc40346f6e9df12bdc7d1f75b2449d5beda20f..1a99e9fa4af0da0ef211a76a59511e569cbd7390 100644 >--- a/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm >+++ b/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm >@@ -98,7 +98,16 @@ OptionSet<WebCore::TouchAction> touchActionsForPoint(UIView *rootView, const Web > if (viewsAtPoint.isEmpty()) > return { WebCore::TouchAction::Auto }; > >- auto *hitView = viewsAtPoint.last(); >+ UIView *hitView; >+ for (auto *view : WTF::makeReversedRange(viewsAtPoint)) { >+ if ([view isKindOfClass:[WKCompositingView class]]) { >+ hitView = view; >+ break; >+ } >+ } >+ >+ if (!hitView) >+ return { WebCore::TouchAction::Auto }; > > CGPoint hitViewPoint = [hitView convertPoint:point fromView:rootView]; >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198275
: 370692