Attachment 370578 Details for Bug 198221 – Patch

[patch] Patch

bug-198221-20190524111728.patch (text/plain), 2.14 KB, created by Devin Rousso on 2019-05-24 11:17:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-05-24 11:17:29 PDT

Size: 2.14 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index e3aa85b0222c695a87a1c48fc8c5653d815906a6..eb5b35f233af2f2d2c442acf57c02456135dc27f 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-05-24  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Overlay: don't show setting for showing rulers/guides during element selection if it's not supported
>+        https://bugs.webkit.org/show_bug.cgi?id=198221
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/SettingsTabContentView.js:
>+        (WI.SettingsTabContentView.prototype._createGeneralSettingsView):
>+
> 2019-05-23  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Overlay: rulers/guides should be shown whenever element selection is enabled
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>index 3ec95633c12421e81edd6f0d50ceaa4afc8701a9..d1b0621394919318963cfa6bb922e91c721e6698 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>@@ -222,9 +222,11 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi
> 
>         generalSettingsView.addSeparator();
> 
>-        generalSettingsView.addSetting(WI.UIString("Element Selection:"), WI.settings.showRulersDuringElementSelection, WI.UIString("Show page rulers and node border lines"));
>+        if (InspectorBackend.domains.DOM && InspectorBackend.domains.DOM.setInspectModeEnabled && InspectorBackend.domains.DOM.setInspectModeEnabled.supports("showRulers")) {
>+            generalSettingsView.addSetting(WI.UIString("Element Selection:"), WI.settings.showRulersDuringElementSelection, WI.UIString("Show page rulers and node border lines"));
> 
>-        generalSettingsView.addSeparator();
>+            generalSettingsView.addSeparator();
>+        }
> 
>         const zoomLevels = [0.6, 0.8, 1, 1.2, 1.4, 1.6, 1.8, 2, 2.2, 2.4];
>         const zoomValues = zoomLevels.map((level) => [level, Number.percentageString(level, 0)]);

Actions: View | Formatted Diff | Diff

Attachments on bug 198221: 370578