Attachment 370564 Details for Bug 198215 – Patch

[patch] Patch

bug-198215-20190523223725.patch (text/plain), 1.58 KB, created by youenn fablet on 2019-05-23 22:37:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-05-23 22:37:26 PDT

Size: 1.58 KB

patch

obsolete

>Subversion Revision: 245568
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 614802412978cd9dc3218dddf25ebfe81721feb4..8d7b5024c88c16be55bee60c28324b389cdc80f2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-05-23  Youenn Fablet  <youenn@apple.com>
>+
>+        Make sure completion handler is always called in SWServer::startSuspension
>+        https://bugs.webkit.org/show_bug.cgi?id=198215
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * workers/service/server/SWServer.cpp:
>+        (WebCore::SWServer::startSuspension):
>+        Make sure completion handler is called in case of no registration store.
>+
> 2019-05-22  Youenn Fablet  <youenn@apple.com>
> 
>         CacheStorageConnection callbacks should be completed on network connection close
>diff --git a/Source/WebCore/workers/service/server/SWServer.cpp b/Source/WebCore/workers/service/server/SWServer.cpp
>index 97b30c15bc90b5fb8b40cdd1cf23b7a0dfe8510f..76541f6099dbf9c61491a94a3c82ad8e5ffcf1df 100644
>--- a/Source/WebCore/workers/service/server/SWServer.cpp
>+++ b/Source/WebCore/workers/service/server/SWServer.cpp
>@@ -220,8 +220,11 @@ void SWServer::clearAll(CompletionHandler<void()>&& completionHandler)
> 
> void SWServer::startSuspension(CompletionHandler<void()>&& completionHandler)
> {
>-    if (m_registrationStore)
>-        m_registrationStore->startSuspension(WTFMove(completionHandler));
>+    if (!m_registrationStore) {
>+        completionHandler();
>+        return;
>+    }
>+    m_registrationStore->startSuspension(WTFMove(completionHandler));
> }
> 
> void SWServer::endSuspension()

Actions: View | Formatted Diff | Diff

Attachments on bug 198215: 370564 | 370568 | 370594