Attachment 370530 Details for Bug 198199 – patch

[patch] patch

c-backup.diff (text/plain), 1.74 KB, created by Saam Barati on 2019-05-23 16:00:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2019-05-23 16:00:13 PDT

Size: 1.74 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 245722)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-05-23  Saam barati  <sbarati@apple.com>
>+
>+        [WHLSL] Make the AST dumper disambiguate expressions using parenthesis to represent AST construction
>+        https://bugs.webkit.org/show_bug.cgi?id=198199
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We would dump "*foo.bar" for "(*foo).bar", which is super confusing.
>+        We now dump "(*foo).bar".
>+
>+        * Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
>+        (WebCore::WHLSL::ASTDumper::visit):
>+
> 2019-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         [WHLSL] Implement property resolver
>Index: Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp
>===================================================================
>--- Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp	(revision 245719)
>+++ Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp	(working copy)
>@@ -419,7 +419,20 @@ void ASTDumper::visit(AST::ForLoop& forL
> 
> void ASTDumper::visit(AST::Expression& expression)
> {
>+    bool skipParens = is<AST::BooleanLiteral>(expression)
>+        || is<AST::FloatLiteral>(expression)
>+        || is<AST::IntegerLiteral>(expression)
>+        || is<AST::NullLiteral>(expression)
>+        || is<AST::UnsignedIntegerLiteral>(expression)
>+        || is<AST::EnumerationMemberLiteral>(expression)
>+        || is<AST::CommaExpression>(expression)
>+        || is<AST::VariableReference>(expression);
>+
>+    if (!skipParens)
>+        m_out.print("(");
>     Base::visit(expression);
>+    if (!skipParens)
>+        m_out.print(")");
> }
> 
> void ASTDumper::visit(AST::DotExpression& dotExpression)

Actions: View | Formatted Diff | Diff

Attachments on bug 198199: 370530