Attachment 370451 Details for Bug 198142 – Patch

[patch] Patch

bug-198142-20190522152422.patch (text/plain), 1.36 KB, created by hysu on 2019-05-22 15:24:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: hysu

Created: 2019-05-22 15:24:23 PDT

Size: 1.36 KB

patch

obsolete

>Subversion Revision: 245594
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 81eabc75e282715dfd8c4ee93533903066283a7f..eb1d4c519c3d2bb24092f80906b0927b3eeaf079 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-05-22  David Xiong  <w_xiong@apple.com>
>+
>+        webkitpy: Using sudo on iOS device during timeout spindumps 
>+        https://bugs.webkit.org/show_bug.cgi?id=198142
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/port/darwin.py:
>+        (DarwinPort.sample_process): Check target host instead of source host for sudo command.
>+
> 2019-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Fix the build with HAVE(ACCESSIBILITY) disabled
>diff --git a/Tools/Scripts/webkitpy/port/darwin.py b/Tools/Scripts/webkitpy/port/darwin.py
>index 33a4bc97b8f05b31f9fef398b61c391350713220..a968680b6d25b47800ddd1e5ddc3b0fa0d6f1fd5 100644
>--- a/Tools/Scripts/webkitpy/port/darwin.py
>+++ b/Tools/Scripts/webkitpy/port/darwin.py
>@@ -168,7 +168,7 @@ class DarwinPort(ApplePort):
>             '-file',
>             DarwinPort.spindump_file_path(host, name, pid, str(tempdir)),
>         ]
>-        if self.host.platform.is_mac():
>+        if host.platform.is_mac():
>             command = ['/usr/bin/sudo', '-n'] + command
>         exit_status = host.executive.run_command(command, return_exit_code=True)
>         if exit_status:

Actions: View | Formatted Diff | Diff

Attachments on bug 198142: 370451