WebKit Bugzilla
Attachment 370446 Details for
Bug 198140
: REGRESSION(r245634): 'This patch makes JSC crash on launch in debug builds' (Requested by tadeuzagallo on #webkit).
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
ROLLOUT of r245634
bug-198140-20190522144632.patch (text/plain), 22.68 KB, created by
WebKit Commit Bot
on 2019-05-22 14:46:33 PDT
(
hide
)
Description:
ROLLOUT of r245634
Filename:
MIME Type:
Creator:
WebKit Commit Bot
Created:
2019-05-22 14:46:33 PDT
Size:
22.68 KB
patch
obsolete
>Subversion Revision: 245647 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index d4f4e15337bad5ff05e34838b674a60f63b7ec21..9d141dfe3700364b88fbdae27fbbe8df539ebe73 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,17 @@ >+2019-05-22 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r245634. >+ https://bugs.webkit.org/show_bug.cgi?id=198140 >+ >+ 'This patch makes JSC crash on launch in debug builds' >+ (Requested by tadeuzagallo on #webkit). >+ >+ Reverted changeset: >+ >+ "[ESNext] Implement support for Numeric Separators" >+ https://bugs.webkit.org/show_bug.cgi?id=196351 >+ https://trac.webkit.org/changeset/245634 >+ > 2019-05-22 Zagallo <tzagallo@apple.com> > > Fix validateExceptionChecks for CLoop >diff --git a/Source/JavaScriptCore/parser/Lexer.cpp b/Source/JavaScriptCore/parser/Lexer.cpp >index a7553f6b3f7f111cedec161b35202281b78c3d33..c2f24bd8f3eaf4ec397a69d5a08b9168a5c1871c 100644 >--- a/Source/JavaScriptCore/parser/Lexer.cpp >+++ b/Source/JavaScriptCore/parser/Lexer.cpp >@@ -813,30 +813,6 @@ static ALWAYS_INLINE bool isIdentPartIncludingEscape(const UChar* code, const UC > return isIdentPartIncludingEscapeTemplate(code, codeEnd); > } > >-template<typename CharacterType> >-static inline bool isASCIIDigitOrSeparator(CharacterType character) >-{ >- return isASCIIDigit(character) || character == '_'; >-} >- >-template<typename CharacterType> >-static inline bool isASCIIHexDigitOrSeparator(CharacterType character) >-{ >- return isASCIIHexDigit(character) || character == '_'; >-} >- >-template<typename CharacterType> >-static inline bool isASCIIBinaryDigitOrSeparator(CharacterType character) >-{ >- return isASCIIBinaryDigit(character) || character == '_'; >-} >- >-template<typename CharacterType> >-static inline bool isASCIIOctalDigitOrSeparator(CharacterType character) >-{ >- return isASCIIOctalDigit(character) || character == '_'; >-} >- > static inline LChar singleEscape(int c) > { > if (c < 128) { >@@ -1514,29 +1490,20 @@ typename Lexer<T>::StringParseResult Lexer<T>::parseTemplateLiteral(JSTokenData* > } > > template <typename T> >-ALWAYS_INLINE auto Lexer<T>::parseHex() -> Optional<NumberParseResult> >+ALWAYS_INLINE auto Lexer<T>::parseHex() -> NumberParseResult > { >- ASSERT(isASCIIHexDigit(m_current)); >- > // Optimization: most hexadecimal values fit into 4 bytes. > uint32_t hexValue = 0; > int maximumDigits = 7; > > do { >- if (m_current == '_') { >- if (UNLIKELY(!isASCIIHexDigit(peek(1)))) >- return WTF::nullopt; >- >- shift(); >- } >- > hexValue = (hexValue << 4) + toASCIIHexValue(m_current); > shift(); > --maximumDigits; >- } while (isASCIIHexDigitOrSeparator(m_current) && maximumDigits >= 0); >+ } while (isASCIIHexDigit(m_current) && maximumDigits >= 0); > > if (LIKELY(maximumDigits >= 0 && m_current != 'n')) >- return NumberParseResult { hexValue }; >+ return hexValue; > > // No more place in the hexValue buffer. > // The values are shifted out and placed into the m_buffer8 vector. >@@ -1549,29 +1516,20 @@ ALWAYS_INLINE auto Lexer<T>::parseHex() -> Optional<NumberParseResult> > hexValue <<= 4; > } > >- while (isASCIIHexDigitOrSeparator(m_current)) { >- if (m_current == '_') { >- if (UNLIKELY(!isASCIIHexDigit(peek(1)))) >- return WTF::nullopt; >- >- shift(); >- } >- >+ while (isASCIIHexDigit(m_current)) { > record8(m_current); > shift(); > } > > if (UNLIKELY(Options::useBigInt() && m_current == 'n')) >- return NumberParseResult { makeIdentifier(m_buffer8.data(), m_buffer8.size()) }; >+ return makeIdentifier(m_buffer8.data(), m_buffer8.size()); > >- return NumberParseResult { parseIntOverflow(m_buffer8.data(), m_buffer8.size(), 16) }; >+ return parseIntOverflow(m_buffer8.data(), m_buffer8.size(), 16); > } > > template <typename T> > ALWAYS_INLINE auto Lexer<T>::parseBinary() -> Optional<NumberParseResult> > { >- ASSERT(isASCIIBinaryDigit(m_current)); >- > // Optimization: most binary values fit into 4 bytes. > uint32_t binaryValue = 0; > const unsigned maximumDigits = 32; >@@ -1581,51 +1539,35 @@ ALWAYS_INLINE auto Lexer<T>::parseBinary() -> Optional<NumberParseResult> > LChar digits[maximumDigits]; > > do { >- if (m_current == '_') { >- if (UNLIKELY(!isASCIIBinaryDigit(peek(1)))) >- return WTF::nullopt; >- >- shift(); >- } >- > binaryValue = (binaryValue << 1) + (m_current - '0'); > digits[digit] = m_current; > shift(); > --digit; >- } while (isASCIIBinaryDigitOrSeparator(m_current) && digit >= 0); >+ } while (isASCIIBinaryDigit(m_current) && digit >= 0); > >- if (LIKELY(!isASCIIDigitOrSeparator(m_current) && digit >= 0 && m_current != 'n')) >- return NumberParseResult { binaryValue }; >+ if (LIKELY(!isASCIIDigit(m_current) && digit >= 0 && m_current != 'n')) >+ return Variant<double, const Identifier*> { binaryValue }; > > for (int i = maximumDigits - 1; i > digit; --i) > record8(digits[i]); > >- while (isASCIIBinaryDigitOrSeparator(m_current)) { >- if (m_current == '_') { >- if (UNLIKELY(!isASCIIBinaryDigit(peek(1)))) >- return WTF::nullopt; >- >- shift(); >- } >- >+ while (isASCIIBinaryDigit(m_current)) { > record8(m_current); > shift(); > } > > if (UNLIKELY(Options::useBigInt() && m_current == 'n')) >- return NumberParseResult { makeIdentifier(m_buffer8.data(), m_buffer8.size()) }; >+ return Variant<double, const Identifier*> { makeIdentifier(m_buffer8.data(), m_buffer8.size()) }; > > if (isASCIIDigit(m_current)) > return WTF::nullopt; > >- return NumberParseResult { parseIntOverflow(m_buffer8.data(), m_buffer8.size(), 2) }; >+ return Variant<double, const Identifier*> { parseIntOverflow(m_buffer8.data(), m_buffer8.size(), 2) }; > } > > template <typename T> > ALWAYS_INLINE auto Lexer<T>::parseOctal() -> Optional<NumberParseResult> > { >- ASSERT(isASCIIOctalDigit(m_current)); >- > // Optimization: most octal values fit into 4 bytes. > uint32_t octalValue = 0; > const unsigned maximumDigits = 10; >@@ -1635,51 +1577,36 @@ ALWAYS_INLINE auto Lexer<T>::parseOctal() -> Optional<NumberParseResult> > LChar digits[maximumDigits]; > > do { >- if (m_current == '_') { >- if (UNLIKELY(!isASCIIOctalDigit(peek(1)))) >- return WTF::nullopt; >- >- shift(); >- } >- > octalValue = octalValue * 8 + (m_current - '0'); > digits[digit] = m_current; > shift(); > --digit; >- } while (isASCIIOctalDigitOrSeparator(m_current) && digit >= 0); >+ } while (isASCIIOctalDigit(m_current) && digit >= 0); >+ >+ if (LIKELY(!isASCIIDigit(m_current) && digit >= 0 && m_current != 'n')) >+ return Variant<double, const Identifier*> { octalValue }; > >- if (LIKELY(!isASCIIDigitOrSeparator(m_current) && digit >= 0 && m_current != 'n')) >- return NumberParseResult { octalValue }; > > for (int i = maximumDigits - 1; i > digit; --i) > record8(digits[i]); > >- while (isASCIIOctalDigitOrSeparator(m_current)) { >- if (m_current == '_') { >- if (UNLIKELY(!isASCIIOctalDigit(peek(1)))) >- return WTF::nullopt; >- >- shift(); >- } >- >+ while (isASCIIOctalDigit(m_current)) { > record8(m_current); > shift(); > } > > if (UNLIKELY(Options::useBigInt() && m_current == 'n')) >- return NumberParseResult { makeIdentifier(m_buffer8.data(), m_buffer8.size()) }; >+ return Variant<double, const Identifier*> { makeIdentifier(m_buffer8.data(), m_buffer8.size()) }; > > if (isASCIIDigit(m_current)) > return WTF::nullopt; > >- return NumberParseResult { parseIntOverflow(m_buffer8.data(), m_buffer8.size(), 8) }; >+ return Variant<double, const Identifier*> { parseIntOverflow(m_buffer8.data(), m_buffer8.size(), 8) }; > } > > template <typename T> > ALWAYS_INLINE auto Lexer<T>::parseDecimal() -> Optional<NumberParseResult> > { >- ASSERT(isASCIIDigit(m_current)); >- > // Optimization: most decimal values fit into 4 bytes. > uint32_t decimalValue = 0; > >@@ -1693,63 +1620,38 @@ ALWAYS_INLINE auto Lexer<T>::parseDecimal() -> Optional<NumberParseResult> > LChar digits[maximumDigits]; > > do { >- if (m_current == '_') { >- if (UNLIKELY(!isASCIIDigit(peek(1)))) >- return WTF::nullopt; >- >- shift(); >- } >- > decimalValue = decimalValue * 10 + (m_current - '0'); > digits[digit] = m_current; > shift(); > --digit; >- } while (isASCIIDigitOrSeparator(m_current) && digit >= 0); >+ } while (isASCIIDigit(m_current) && digit >= 0); > > if (digit >= 0 && m_current != '.' && !isASCIIAlphaCaselessEqual(m_current, 'e') && m_current != 'n') >- return NumberParseResult { decimalValue }; >+ return Variant<double, const Identifier*> { decimalValue }; > > for (int i = maximumDigits - 1; i > digit; --i) > record8(digits[i]); > } > >- while (isASCIIDigitOrSeparator(m_current)) { >- if (m_current == '_') { >- if (UNLIKELY(!isASCIIDigit(peek(1)))) >- return WTF::nullopt; >- >- shift(); >- } >- >+ while (isASCIIDigit(m_current)) { > record8(m_current); > shift(); > } > > if (UNLIKELY(Options::useBigInt() && m_current == 'n')) >- return NumberParseResult { makeIdentifier(m_buffer8.data(), m_buffer8.size()) }; >+ return Variant<double, const Identifier*> { makeIdentifier(m_buffer8.data(), m_buffer8.size()) }; > > return WTF::nullopt; > } > > template <typename T> >-ALWAYS_INLINE bool Lexer<T>::parseNumberAfterDecimalPoint() >+ALWAYS_INLINE void Lexer<T>::parseNumberAfterDecimalPoint() > { >- ASSERT(isASCIIDigit(m_current)); > record8('.'); >- >- do { >- if (m_current == '_') { >- if (UNLIKELY(!isASCIIDigit(peek(1)))) >- return false; >- >- shift(); >- } >- >+ while (isASCIIDigit(m_current)) { > record8(m_current); > shift(); >- } while (isASCIIDigitOrSeparator(m_current)); >- >- return true; >+ } > } > > template <typename T> >@@ -1766,17 +1668,9 @@ ALWAYS_INLINE bool Lexer<T>::parseNumberAfterExponentIndicator() > return false; > > do { >- if (m_current == '_') { >- if (UNLIKELY(!isASCIIDigit(peek(1)))) >- return false; >- >- shift(); >- } >- > record8(m_current); > shift(); >- } while (isASCIIDigitOrSeparator(m_current)); >- >+ } while (isASCIIDigit(m_current)); > return true; > } > >@@ -2196,11 +2090,7 @@ start: > token = DOT; > break; > } >- if (UNLIKELY(!parseNumberAfterDecimalPoint())) { >- m_lexErrorMessage = "Non-number found after decimal point"_s; >- token = INVALID_NUMERIC_LITERAL_ERRORTOK; >- goto returnError; >- } >+ parseNumberAfterDecimalPoint(); > token = DOUBLE; > if (isASCIIAlphaCaselessEqual(m_current, 'e')) { > if (!parseNumberAfterExponentIndicator()) { >@@ -2234,14 +2124,12 @@ start: > shift(); > > auto parseNumberResult = parseHex(); >- if (!parseNumberResult) >- tokenData->doubleValue = 0; >- else if (WTF::holds_alternative<double>(*parseNumberResult)) >- tokenData->doubleValue = WTF::get<double>(*parseNumberResult); >+ if (WTF::holds_alternative<double>(parseNumberResult)) >+ tokenData->doubleValue = WTF::get<double>(parseNumberResult); > else { > token = BIGINT; > shift(); >- tokenData->bigIntString = WTF::get<const Identifier*>(*parseNumberResult); >+ tokenData->bigIntString = WTF::get<const Identifier*>(parseNumberResult); > tokenData->radix = 16; > } > >@@ -2321,12 +2209,6 @@ start: > break; > } > >- if (UNLIKELY(m_current == '_')) { >- m_lexErrorMessage = "Numeric literals may not begin with 0_"_s; >- token = UNTERMINATED_OCTAL_NUMBER_ERRORTOK; >- goto returnError; >- } >- > record8('0'); > if (strictMode && isASCIIDigit(m_current)) { > m_lexErrorMessage = "Decimal integer literals with a leading zero are forbidden in strict mode"_s; >@@ -2358,11 +2240,7 @@ start: > token = INTEGER; > if (m_current == '.') { > shift(); >- if (UNLIKELY(isASCIIDigit(m_current) && !parseNumberAfterDecimalPoint())) { >- m_lexErrorMessage = "Non-number found after decimal point"_s; >- token = INVALID_NUMERIC_LITERAL_ERRORTOK; >- goto returnError; >- } >+ parseNumberAfterDecimalPoint(); > token = DOUBLE; > } > if (isASCIIAlphaCaselessEqual(m_current, 'e')) { >diff --git a/Source/JavaScriptCore/parser/Lexer.h b/Source/JavaScriptCore/parser/Lexer.h >index cf3780bbc46be564ef89b30a632530051fd846c5..3755437e93d2d7fcee2ef8e325e1ffe1d37f3ad9 100644 >--- a/Source/JavaScriptCore/parser/Lexer.h >+++ b/Source/JavaScriptCore/parser/Lexer.h >@@ -179,11 +179,11 @@ private: > ALWAYS_INLINE StringParseResult parseTemplateLiteral(JSTokenData*, RawStringsBuildMode); > > using NumberParseResult = Variant<double, const Identifier*>; >- ALWAYS_INLINE Optional<NumberParseResult> parseHex(); >+ ALWAYS_INLINE NumberParseResult parseHex(); > ALWAYS_INLINE Optional<NumberParseResult> parseBinary(); > ALWAYS_INLINE Optional<NumberParseResult> parseOctal(); > ALWAYS_INLINE Optional<NumberParseResult> parseDecimal(); >- ALWAYS_INLINE bool parseNumberAfterDecimalPoint(); >+ ALWAYS_INLINE void parseNumberAfterDecimalPoint(); > ALWAYS_INLINE bool parseNumberAfterExponentIndicator(); > ALWAYS_INLINE bool parseMultilineComment(); > >diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog >index 34573cde95c304c255f904685606933e73d01dfb..016fe014926479921280074dd526759f0392d761 100644 >--- a/JSTests/ChangeLog >+++ b/JSTests/ChangeLog >@@ -1,3 +1,17 @@ >+2019-05-22 Commit Queue <commit-queue@webkit.org> >+ >+ Unreviewed, rolling out r245634. >+ https://bugs.webkit.org/show_bug.cgi?id=198140 >+ >+ 'This patch makes JSC crash on launch in debug builds' >+ (Requested by tadeuzagallo on #webkit). >+ >+ Reverted changeset: >+ >+ "[ESNext] Implement support for Numeric Separators" >+ https://bugs.webkit.org/show_bug.cgi?id=196351 >+ https://trac.webkit.org/changeset/245634 >+ > 2019-05-22 Tadeu Zagallo <tzagallo@apple.com> > > Stack-buffer-overflow in decodeURIComponent >diff --git a/JSTests/test262/expectations.yaml b/JSTests/test262/expectations.yaml >index 9cbe35d3128956cbc98e38be585bb427ee201af8..e37273d811d29aa62b9a0d77c6605c638d66192d 100644 >--- a/JSTests/test262/expectations.yaml >+++ b/JSTests/test262/expectations.yaml >@@ -2586,6 +2586,96 @@ test/language/global-code/script-decl-func-err-non-extensible.js: > test/language/global-code/script-decl-var-err.js: > default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all' > strict mode: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all' >+test/language/literals/numeric/numeric-separator-literal-bil-bd-nsl-bd.js: >+ default: 'SyntaxError: No space between binary literal and identifier' >+ strict mode: 'SyntaxError: No space between binary literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-bil-bd-nsl-bds.js: >+ default: 'SyntaxError: No space between binary literal and identifier' >+ strict mode: 'SyntaxError: No space between binary literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-bil-bds-nsl-bd.js: >+ default: 'SyntaxError: No space between binary literal and identifier' >+ strict mode: 'SyntaxError: No space between binary literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-bil-bds-nsl-bds.js: >+ default: 'SyntaxError: No space between binary literal and identifier' >+ strict mode: 'SyntaxError: No space between binary literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-dd-dot-dd-ep-sign-minus-dd-nsl-dd.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-dd-dot-dd-ep-sign-minus-dds-nsl-dd.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-dd-dot-dd-ep-sign-plus-dd-nsl-dd.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-dd-dot-dd-ep-sign-plus-dds-nsl-dd.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-dd-nsl-dd-one-of.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-dds-dot-dd-nsl-dd-ep-dd.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-dds-nsl-dd.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-dot-dd-nsl-dd-ep.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-dot-dd-nsl-dds-ep.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-dot-dds-nsl-dd-ep.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-dot-dds-nsl-dds-ep.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-hil-hd-nsl-hd.js: >+ default: 'SyntaxError: No space between hexadecimal literal and identifier' >+ strict mode: 'SyntaxError: No space between hexadecimal literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-hil-hd-nsl-hds.js: >+ default: 'SyntaxError: No space between hexadecimal literal and identifier' >+ strict mode: 'SyntaxError: No space between hexadecimal literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-hil-hds-nsl-hd.js: >+ default: 'SyntaxError: No space between hexadecimal literal and identifier' >+ strict mode: 'SyntaxError: No space between hexadecimal literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-hil-hds-nsl-hds.js: >+ default: 'SyntaxError: No space between hexadecimal literal and identifier' >+ strict mode: 'SyntaxError: No space between hexadecimal literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-hil-od-nsl-od-one-of.js: >+ default: 'SyntaxError: No space between hexadecimal literal and identifier' >+ strict mode: 'SyntaxError: No space between hexadecimal literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-nzd-nsl-dd-one-of.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-nzd-nsl-dd.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-nzd-nsl-dds.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-oil-od-nsl-od-one-of.js: >+ default: 'SyntaxError: No space between octal literal and identifier' >+ strict mode: 'SyntaxError: No space between octal literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-oil-od-nsl-od.js: >+ default: 'SyntaxError: No space between octal literal and identifier' >+ strict mode: 'SyntaxError: No space between octal literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-oil-od-nsl-ods.js: >+ default: 'SyntaxError: No space between octal literal and identifier' >+ strict mode: 'SyntaxError: No space between octal literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-oil-ods-nsl-od.js: >+ default: 'SyntaxError: No space between octal literal and identifier' >+ strict mode: 'SyntaxError: No space between octal literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-oil-ods-nsl-ods.js: >+ default: 'SyntaxError: No space between octal literal and identifier' >+ strict mode: 'SyntaxError: No space between octal literal and identifier' >+test/language/literals/numeric/numeric-separator-literal-sign-minus-dds-nsl-dd.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' >+test/language/literals/numeric/numeric-separator-literal-sign-plus-dds-nsl-dd.js: >+ default: 'SyntaxError: No identifiers allowed directly after numeric literal' >+ strict mode: 'SyntaxError: No identifiers allowed directly after numeric literal' > test/language/literals/regexp/named-groups/invalid-dangling-groupname-2-u.js: > default: 'Test262: This statement should not be evaluated.' > strict mode: 'Test262: This statement should not be evaluated.'
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=370446">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198140
: 370446