Attachment 370443 Details for Bug 198067 – Adds null check

[patch] Adds null check

bug-198067-20190522140237.patch (text/plain), 1.49 KB, created by Ryosuke Niwa on 2019-05-22 14:02:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2019-05-22 14:02:38 PDT

Size: 1.49 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 245560)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-05-20  Ryosuke Niwa  <rniwa@webkit.org>
>+
>+        Crash in WebFrame::jsContext() when m_coreFrame is null
>+        https://bugs.webkit.org/show_bug.cgi?id=198067
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Added missing null checks. Unfortunately no new tests since we don't have a reproducible test case.
>+
>+        * WebProcess/WebPage/WebFrame.cpp:
>+        (WebKit::WebFrame::jsContext):
>+        (WebKit::WebFrame::jsContextForWorld):
>+
> 2019-05-20  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         Make lossy LayoutUnit constructors explicit
>Index: Source/WebKit/WebProcess/WebPage/WebFrame.cpp
>===================================================================
>--- Source/WebKit/WebProcess/WebPage/WebFrame.cpp	(revision 245545)
>+++ Source/WebKit/WebProcess/WebPage/WebFrame.cpp	(working copy)
>@@ -520,11 +520,17 @@ bool WebFrame::allowsFollowingLink(const
> 
> JSGlobalContextRef WebFrame::jsContext()
> {
>+    if (!m_coreFrame)
>+        return nullptr;
>+
>     return toGlobalRef(m_coreFrame->script().globalObject(mainThreadNormalWorld())->globalExec());
> }
> 
> JSGlobalContextRef WebFrame::jsContextForWorld(InjectedBundleScriptWorld* world)
> {
>+    if (!m_coreFrame)
>+        return nullptr;
>+
>     return toGlobalRef(m_coreFrame->script().globalObject(world->coreWorld())->globalExec());
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198067: 370443