Attachment 370385 Details for Bug 195777 – Patch

[patch] Patch

bug-195777-20190522005352.patch (text/plain), 3.07 KB, created by Devin Rousso on 2019-05-22 00:53:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-05-22 00:53:53 PDT

Size: 3.07 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index e2a174b8ff38cc9df4579b5d3aa60fd15015126d..0ebefb445186e3764129cd092f6534ce8f6bd88c 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-05-22  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: provide a way to reset all settings
>+        https://bugs.webkit.org/show_bug.cgi?id=195777
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This makes it much easier to reset Web Inspector to a consistent state for testing.
>+
>+        * UserInterface/Base/Setting.js:
>+        (WI.Setting.reset): Added.
>+
>+        * UserInterface/Views/SettingsTabContentView.js:
>+        (WI.SettingsTabContentView.prototype._createDebugSettingsView):
>+
> 2019-05-20  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Storage tab crashes easily when adding new local/session storage entries.
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Setting.js b/Source/WebInspectorUI/UserInterface/Base/Setting.js
>index b3c6e575e440e5b475e68534ca045a352ef25794..f27691a8c6e77c401e2e270aa01309fef777f9d5 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Setting.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Setting.js
>@@ -58,6 +58,21 @@ WI.Setting = class Setting extends WI.Object
>         return value;
>     }
> 
>+    static reset()
>+    {
>+        let prefix = Setting._localStorageKey("");
>+
>+        let keysToRemove = [];
>+        for (let i = 0; i < window.localStorage.length; ++i) {
>+            let key = window.localStorage.key(i);
>+            if (key.startsWith(prefix))
>+                keysToRemove.push(key);
>+        }
>+
>+        for (let key of keysToRemove)
>+            window.localStorage.removeItem(key);
>+    }
>+
>     static _localStorageKey(name)
>     {
>         let inspectionLevel = InspectorFrontendHost ? InspectorFrontendHost.inspectionLevel() : 1;
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>index 08066cd476640c68cca97307a60f9ca3c14213d9..4aa3d88fb8ccdfa022e3f9d0ae4fce15bf3e04ae 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
>@@ -356,6 +356,15 @@ WI.SettingsTabContentView = class SettingsTabContentView extends WI.TabContentVi
>         layoutDirectionEditor.value = WI.settings.layoutDirection.value;
>         layoutDirectionEditor.addEventListener(WI.SettingEditor.Event.ValueDidChange, () => { WI.setLayoutDirection(layoutDirectionEditor.value); });
> 
>+        let resetInspectorButton = document.createElement("button");
>+        resetInspectorButton.textContent = WI.unlocalizedString("Reset Web Inspector");
>+        resetInspectorButton.addEventListener("click", (event) => {
>+            WI.Setting.reset();
>+            WI.ObjectStore.reset();
>+            InspectorFrontendHost.reopen();
>+        });
>+        this._debugSettingsView.addCenteredContainer(resetInspectorButton);
>+
>         this.addSettingsView(this._debugSettingsView);
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 195777: 364740 | 364741 | 364742 | 364754 | 364885 | 370385 | 370454