Attachment 370371 Details for Bug 198100 – Patch

[patch] Patch

bug-198100-20190521190632.patch (text/plain), 9.01 KB, created by Myles C. Maxfield on 2019-05-21 19:06:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Myles C. Maxfield

Created: 2019-05-21 19:06:33 PDT

Size: 9.01 KB

patch

obsolete

>Subversion Revision: 245598
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index ab28ffad21c9fe0b4ec9a102b153ddf965802e1e..de6017a9a09f45337365310f9b405f776604c326 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-05-21  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [Apple] Enable variation fonts on all Apple platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=198100
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2019-05-21  Tadeu Zagallo  <tzagallo@apple.com>
> 
>         Fix production build after r245564
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d7075b86e30f294f61836b3958de13b480283041..88482409bd96a7baa8f197fdc8c83edca9a7b824 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-05-21  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [Apple] Enable variation fonts on all Apple platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=198100
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2019-05-21  Myles C. Maxfield  <mmaxfield@apple.com>
> 
>         font-optical-sizing applies the wrong variation value
>diff --git a/Source/WebCore/PAL/ChangeLog b/Source/WebCore/PAL/ChangeLog
>index 319be992f9ce14a369a12459ebbc620b134ff4fa..fba8e56dd53e176e64abfc0f12ba4428200f1d98 100644
>--- a/Source/WebCore/PAL/ChangeLog
>+++ b/Source/WebCore/PAL/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-05-21  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [Apple] Enable variation fonts on all Apple platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=198100
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2019-05-17  Don Olmstead  <don.olmstead@sony.com>
> 
>         [CMake] Use builtin FindICU
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 91911cd871a3f8482cfe62e9553417551bed1a64..3015558dd3e0759eb9e7a0907d78c8bf3c2bf5dd 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-05-21  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [Apple] Enable variation fonts on all Apple platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=198100
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2019-05-21  Alex Christensen  <achristensen@webkit.org>
> 
>         Mark WKUIDelegate webView:shouldPreviewElement: and webView:previewingViewControllerForElement:defaultActions: as deprecated
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index f9700f31fcdf87a1b12f01c1e2a74f5067871fab..86ae2fcd7014b99318c3a0c467274d1919043473 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-05-21  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [Apple] Enable variation fonts on all Apple platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=198100
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Configurations/FeatureDefines.xcconfig:
>+
> 2019-05-21  Alex Christensen  <achristensen@webkit.org>
> 
>         Fix IOSMAC build
>diff --git a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>index 9e11c6785fae3b0ceb78b4a29a7239b81494ebb8..8497299982c4a752726d9e8196da619d187f5225 100644
>--- a/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>+++ b/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
>@@ -380,6 +380,8 @@ ENABLE_VARIATION_FONTS = $(ENABLE_VARIATION_FONTS_$(WK_PLATFORM_NAME));
> ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iosmac = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_watchos = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_appletvos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_macosx = $(ENABLE_VARIATION_FONTS$(WK_MACOS_1013));
> ENABLE_VARIATION_FONTS_MACOS_SINCE_1013 = ENABLE_VARIATION_FONTS;
> 
>diff --git a/Source/WebCore/Configurations/FeatureDefines.xcconfig b/Source/WebCore/Configurations/FeatureDefines.xcconfig
>index 9e11c6785fae3b0ceb78b4a29a7239b81494ebb8..8497299982c4a752726d9e8196da619d187f5225 100644
>--- a/Source/WebCore/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebCore/Configurations/FeatureDefines.xcconfig
>@@ -380,6 +380,8 @@ ENABLE_VARIATION_FONTS = $(ENABLE_VARIATION_FONTS_$(WK_PLATFORM_NAME));
> ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iosmac = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_watchos = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_appletvos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_macosx = $(ENABLE_VARIATION_FONTS$(WK_MACOS_1013));
> ENABLE_VARIATION_FONTS_MACOS_SINCE_1013 = ENABLE_VARIATION_FONTS;
> 
>diff --git a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
>index 9e11c6785fae3b0ceb78b4a29a7239b81494ebb8..8497299982c4a752726d9e8196da619d187f5225 100644
>--- a/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
>@@ -380,6 +380,8 @@ ENABLE_VARIATION_FONTS = $(ENABLE_VARIATION_FONTS_$(WK_PLATFORM_NAME));
> ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iosmac = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_watchos = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_appletvos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_macosx = $(ENABLE_VARIATION_FONTS$(WK_MACOS_1013));
> ENABLE_VARIATION_FONTS_MACOS_SINCE_1013 = ENABLE_VARIATION_FONTS;
> 
>diff --git a/Source/WebKit/Configurations/FeatureDefines.xcconfig b/Source/WebKit/Configurations/FeatureDefines.xcconfig
>index 9e11c6785fae3b0ceb78b4a29a7239b81494ebb8..8497299982c4a752726d9e8196da619d187f5225 100644
>--- a/Source/WebKit/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebKit/Configurations/FeatureDefines.xcconfig
>@@ -380,6 +380,8 @@ ENABLE_VARIATION_FONTS = $(ENABLE_VARIATION_FONTS_$(WK_PLATFORM_NAME));
> ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iosmac = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_watchos = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_appletvos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_macosx = $(ENABLE_VARIATION_FONTS$(WK_MACOS_1013));
> ENABLE_VARIATION_FONTS_MACOS_SINCE_1013 = ENABLE_VARIATION_FONTS;
> 
>diff --git a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
>index 9e11c6785fae3b0ceb78b4a29a7239b81494ebb8..8497299982c4a752726d9e8196da619d187f5225 100644
>--- a/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
>+++ b/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
>@@ -380,6 +380,8 @@ ENABLE_VARIATION_FONTS = $(ENABLE_VARIATION_FONTS_$(WK_PLATFORM_NAME));
> ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iosmac = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_watchos = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_appletvos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_macosx = $(ENABLE_VARIATION_FONTS$(WK_MACOS_1013));
> ENABLE_VARIATION_FONTS_MACOS_SINCE_1013 = ENABLE_VARIATION_FONTS;
> 
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 81eabc75e282715dfd8c4ee93533903066283a7f..87de13b4c724a9bc20afb6a06f8ff796a57d2115 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-05-21  Myles C. Maxfield  <mmaxfield@apple.com>
>+
>+        [Apple] Enable variation fonts on all Apple platforms
>+        https://bugs.webkit.org/show_bug.cgi?id=198100
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
>+
> 2019-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Fix the build with HAVE(ACCESSIBILITY) disabled
>diff --git a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
>index 9e11c6785fae3b0ceb78b4a29a7239b81494ebb8..8497299982c4a752726d9e8196da619d187f5225 100644
>--- a/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
>+++ b/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
>@@ -380,6 +380,8 @@ ENABLE_VARIATION_FONTS = $(ENABLE_VARIATION_FONTS_$(WK_PLATFORM_NAME));
> ENABLE_VARIATION_FONTS_iphoneos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iosmac = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_iphonesimulator = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_watchos = ENABLE_VARIATION_FONTS;
>+ENABLE_VARIATION_FONTS_appletvos = ENABLE_VARIATION_FONTS;
> ENABLE_VARIATION_FONTS_macosx = $(ENABLE_VARIATION_FONTS$(WK_MACOS_1013));
> ENABLE_VARIATION_FONTS_MACOS_SINCE_1013 = ENABLE_VARIATION_FONTS;
>

Flags:

simon.fraser: review+
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 198100: 370371 | 383668